feat(skillify): add review-only push preview - #335
Open
LittlePeter52012 wants to merge 5 commits into
Open
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughChangesSkillify review workflow
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant CLI as skillify push
participant Config as loadScopeConfig
participant Push as runPush
CLI->>Config: load configuration with migrateLegacy=false
CLI->>Push: run dry-run push
Push-->>CLI: return candidate source and proposed version
CLI-->>CLI: validate content and escape metadata
CLI-->>CLI: display review output without publishing
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/claude-code/skillify-cli.test.ts`:
- Line 371: Update tests/claude-code/skillify-cli.test.ts lines 371-371 and
383-383: store each unsafe candidate in a variable, then assert the complete
rejection message using candidate.indexOf() to verify the exact ESC and U+202E
offsets rather than only matching generic prefixes.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 2d519133-4959-44ea-a94f-1c37848dac02
📒 Files selected for processing (7)
harnesses/pi/extension-source/hivemind.tssrc/cli/skillify-spec.tssrc/commands/skillify.tssrc/skillify/push.tssrc/skillify/scope-config.tstests/claude-code/skillify-cli.test.tstests/claude-code/skillify-scope-config.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hivemind skillify push <skill-name> --reviewas a pre-publication review stepThis is a narrow foundation for the README roadmap item Skill versioning and review: it adds a deterministic human-review checkpoint without introducing approval state or schema changes.
Version Bump
No release is requested from this contributor PR, so
package.jsonis unchanged. Maintainers can include the feature in their next planned release.Test plan
npx vitest run tests/claude-code/skillify-cli.test.ts tests/claude-code/skillify-scope-config.test.ts tests/shared/skillify-push.test.ts tests/cli/skillify-spec-self-drift.test.ts tests/pi/skillify-spec-drift.test.ts tests/claude-code/skillify-session-start-injection.test.tsnpm run typechecknpm run buildgit diff origin/main...HEAD --checkTests pass locally (
npm test; see baseline note below)Relevant new tests added
No release requested;
package.jsonnot bumpedFull-suite baseline
npm testreports 15 failures and 5800 passes. The same 15 failures reproduce on unmodifiedmain, in notifications, plugin cache GC, Cowork installation, skillify project-key normalization, and graph tests; this change adds no new full-suite failures.Summary by CodeRabbit
skillify push --reviewto preview candidate content and the proposed version without publishing.