Skip to content

Comments: Generalize ping handling with an is_ping comment type flag#63

Draft
adamsilverstein wants to merge 1 commit into
fcc/comment-type-render-callbackfrom
fcc/comment-type-ping-grouping
Draft

Comments: Generalize ping handling with an is_ping comment type flag#63
adamsilverstein wants to merge 1 commit into
fcc/comment-type-render-callbackfrom
fcc/comment-type-ping-grouping

Conversation

@adamsilverstein

Copy link
Copy Markdown
Owner

Add an is_ping flag to WP_Comment_Type (built-in pingback and trackback set
it). separate_comments() now groups any registered ping type into the pings
bucket, and Walker_Comment renders any ping type with the compact ping markup,
replacing the literal 'pingback' / 'trackback' string checks.

Rebuilt from #54 as
part of a stacked-PR trial.

Trac ticket: https://core.trac.wordpress.org/ticket/35214


Stack created with GitHub Stacks CLIGive Feedback 💬

Add an is_ping flag to WP_Comment_Type (built-in pingback and trackback set
it). separate_comments() now groups any registered ping type into the pings
bucket, and Walker_Comment renders any ping type with the compact ping markup,
replacing the literal 'pingback' / 'trackback' string checks.

Rebuilt from #54 as
part of a stacked-PR trial.

Trac ticket: https://core.trac.wordpress.org/ticket/35214
@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 28a6b535-85f8-482c-866a-255481c92e72

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fcc/comment-type-ping-grouping

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant