Comments: Generalize ping handling with an is_ping comment type flag#63
Draft
adamsilverstein wants to merge 1 commit into
Draft
Comments: Generalize ping handling with an is_ping comment type flag#63adamsilverstein wants to merge 1 commit into
adamsilverstein wants to merge 1 commit into
Conversation
Add an is_ping flag to WP_Comment_Type (built-in pingback and trackback set it). separate_comments() now groups any registered ping type into the pings bucket, and Walker_Comment renders any ping type with the compact ping markup, replacing the literal 'pingback' / 'trackback' string checks. Rebuilt from #54 as part of a stacked-PR trial. Trac ticket: https://core.trac.wordpress.org/ticket/35214
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an is_ping flag to WP_Comment_Type (built-in pingback and trackback set
it). separate_comments() now groups any registered ping type into the pings
bucket, and Walker_Comment renders any ping type with the compact ping markup,
replacing the literal 'pingback' / 'trackback' string checks.
Rebuilt from #54 as
part of a stacked-PR trial.
Trac ticket: https://core.trac.wordpress.org/ticket/35214
Stack created with GitHub Stacks CLI • Give Feedback 💬