Skip to content

add path to endpoint.ex in installation guide for Phoenix 1.7 - #293

Open
azyzz228 wants to merge 1 commit into
aesmail:masterfrom
azyzz228:master
Open

azyzz228 wants to merge 1 commit into
aesmail:masterfrom
azyzz228:master

Conversation

@azyzz228

Copy link
Copy Markdown

Added clarification for newbies (like me) on where (endpoint) to enable Router Helpers so that kaffy works in Phoenix 1.7

Added clarification for newbies (like me) on where (endpoint) to enable Router Helpers so that kaffy works in Phoenix 1.7
@lewazo

lewazo commented Sep 18, 2023

Copy link
Copy Markdown

This is usually not in endpoint.ex, but in lib/your_app_web.ex.

Comment thread README.md

You will also need to change `helpers: false` to `true` as shown in example below.
```elixir
# in your lib/you_app_web/endpoint.ex

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition! Don't know how the filename wasn't mentioned here!
Just to be consistent with the rest of the docs, since we're using "my app" instead of "your app", could you please make this lib/my_app_web.ex and it'll be ready to merge.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oooh my bad =D

@ghenry

ghenry commented Apr 25, 2024

Copy link
Copy Markdown
Collaborator

Can we fix this up again and I'll merge. Thanks for your contribution!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants