Fix multiprocessing on Windows and update README for v0.3.0 - #49
Merged
Merged
Conversation
_get_mp_context asked for "forkserver" on every platform except macOS, but forkserver is Unix-only. On Windows every pooled chemistry helper (fingerprints_from_smiles, molecular_properties, murcko_scaffolds) failed with "cannot find context for 'forkserver'" before any RDKit work started. Use "spawn" on Windows as well as macOS. Fixes #48 Claude-Session: https://claude.ai/code/session_0126UJi2YmQewF8Sn35tXh16
The Quick Start called write_html and show on the TMAP model; those live on TmapViz, so the first example in the README raised an AttributeError. Route both snippets through to_tmapviz() and add the missing imports. Also bring the README up to date with v0.3.0: return_valid in fingerprints_from_smiles, hop counts, kNN component bridging, the reproducible flag, the inspector (neighbors, tree paths, colour by tree distance), add_filter, configure_column, 3D structure helpers, the full list of domain utilities, and a pointer to the examples index. Qualify the determinism claim: the layout is always deterministic, the HNSW build only with reproducible=True. State that wheels are built for Linux x86_64 and macOS arm64 only and that Windows is unsupported (use WSL2), and add matching Operating System classifiers to pyproject.toml. Claude-Session: https://claude.ai/code/session_0126UJi2YmQewF8Sn35tXh16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #48
_get_mp_contextasked for theforkserverstart method on every platform except macOS.forkserveris Unix-only, so on Windows every pooled chemistry helper (fingerprints_from_smiles,molecular_properties,murcko_scaffolds) failed withcannot find context for 'forkserver'. Windows now usesspawn, with regression tests.Windows remains untested and unsupported. Wheels are built for Linux x86_64 and macOS arm64 only. The README now says so and points to WSL2, and
pyproject.tomlgets matching Operating System classifiers.The README Quick Start also called
write_htmlandshowon theTMAPmodel. Those methods live onTmapViz, so the first example raised anAttributeError. Both snippets now go throughto_tmapviz(). The rest of the README is brought up to v0.3.0:return_valid, hop counts, kNN component bridging,reproducible, the inspector (neighbors, tree paths, colour by tree distance),add_filter,configure_column, 3D structure helpers, the full domain-utilities list, and a link to the examples index.