Repository navigation
Conversation
The route and ModelSelector both sorted models by display name, so a models.json provider lost the order its file gives. pi's TUI selector never sorts by name: a scope keeps its enabledModels order, and the full list is sorted by provider id only, keeping the registry (file) order within each provider. The name sort came in as a side change of #80. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The route and
ModelSelectorboth sorted models by display name, so a models.json provider lost the order its file gives (#783).pi's own
/modelselector never sorts by name:enabledModelsset it lists the scope in the order the patterns are written (a glob expands in config order);The name sort came in as a side bullet of #80 ("Sort model options alphabetically"); no issue asked for it.
lib/model-scope.ts: neworderSelectorModels()gives pi's order;app/api/models/route.tsuses it.components/ModelSelector.tsxno longer re-sorts; it still groups by provider (first-appearance order).docs/agents/models.mdnotes the rule.Tests:
lib/model-scope.test.mjs,components/ModelSelector.test.mjs(+ a regex incomponents/AgentsConfig.test.mjs). Checked against the real SDK with a scratch models.json that file order is kept.tsc, eslint,npm testpass.Closes #783
🤖 Generated with Claude Code