feat: support path-prefix canonical base URLs in --canonical-origin - #102
Open
philip wants to merge 2 commits into
Open
feat: support path-prefix canonical base URLs in --canonical-origin#102philip wants to merge 2 commits into
philip wants to merge 2 commits into
Conversation
A canonical like https://prod.com/docs// left a trailing slash in the normalized value, so the rewrite regex silently matched nothing. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--canonical-originpreviously accepted only an origin, so it worked when production and preview shared the same path structure. But when production docs live under a path prefix (e.g.https://example.com/docs) and the preview serves from a different base, an origin swap produces broken URLs.This PR lets the flag accept an origin plus a path prefix. When a prefix is given, matching URLs in fetched content are rewritten to the full target base instead of just swapping origins.
Along the way this fixes two latent issues in the canonical-origin rewrite itself: a
$in the target URL was interpreted as a replacement pattern, and URLs ending at?,#,), or,(markdown links, prose) weren't matched. The canonical value is also normalized consistently now (trailing slashes, host case, default ports).Verified end to end against a real deploy: a Vercel preview of neon.com/docs scored identically to production with
--canonical-origin https://neon.com/docs.🤖 Generated with Claude Code