fix: cap train ncu at --target minor - #289
Merged
Merged
Conversation
Contributor
|
🎉 PR Validation ✅ PASSED Commit: Checks:
Ready to merge! ✨ 🔗 View workflow run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Friday train's
npx npm-check-updates -u --dep prod,dev --filter "@agentage/*"had no major guard and force-bumped@agentage/memory-core^0.5.0 -> ^1.0.0 (breaking rewrite), failingnpm run verifyon TS2305 - run 32527573819 red. This defeated the deliberate major-ignore merged in #286.Fix: add
--target minorto the ncu invocation so majors stay a deliberate human/dependabot call.Dry-run evidence in the worktree (
npx npm-check-updates --filter "@agentage/*" --target minor, no-u): "All dependencies match the minor package versions :)" - does NOT propose memory-core ^1.0.x. Without the cap, ncu currently proposes@agentage/memory-core ^0.5.0 -> ^1.0.1.