fix(bitcoin): validate Base58Check and Bech32/Bech32m address checksums (#21) - #22
Closed
meridianmindx wants to merge 1 commit into
Closed
fix(bitcoin): validate Base58Check and Bech32/Bech32m address checksums (#21)#22meridianmindx wants to merge 1 commit into
meridianmindx wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #21
Summary of Changes
createHash("sha256")) of the 21-byte version+payload slice for legacy (P2PKH0x00and P2SH0x05) addresses.14zMkTgaVXJcxdh4JdWi29MLRR44iUSG9Wvs corrupted14zMkTgaVXJcxdh4JdWi29MLRR44iUSG9X).bcHRP and 5-bit data values.1) for SegWit v0 (bc1q...) addresses and BIP-350 constant (0x2bc830a3) for SegWit v1+ (Taprootbc1p...) addresses.bc1qaxm5p35r3yl25rdh5ex0j6wx33peht9r735x90vs corruptedbc1qaxm5p35r3yl25rdh5ex0j6wx33peht9r735x9q).Verification
vitest run→ 122/122 unit tests passing (5/5 test files).oxlint .→ 0 errors, 0 warnings.oxfmt --check .→ clean formatting.tsc --noEmit&tsc --noEmit -p tsconfig.extensions.json→ clean typecheck.obuild→ clean build output across CLI, MCP, and library entries.Base Payout Address:
0xcFDa9f32d292661740a6d0B4c00867E34c05c56D