review(bandcamp): add deterministic task verifiers - #79
Open
reacher-z wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewer contribution
This builds on #36 while preserving XuanRui LI's original Bandcamp commit and authorship. The reviewer changes are isolated in a second commit.
What changed
main, retaining Merriam-Webster and assigning Bandcamp the next available port40016judge_rubricandverifier_pathcontracts without leaking ananswerfieldVerification
python3 -m unittest discover -s sites/bandcamp/verify -p 'test_*.py' -v: 7 test groups passpy_compile, JSONL parsing, shell syntax,git diff --check, and asset checks passAsset dependency
The companion asset submission remains ChilleD/WebHarbor discussion #26. It should be merged/pinned before this environment is treated as self-contained.
This branch independently uses the next free port on current
main. If the Cookpad reviewer PR #78 lands first, I will rebase this branch and move Bandcamp to40017so both environments remain conflict-free.