Skip to content

review(wineaccess): add deterministic task verifiers - #81

Open
reacher-z wants to merge 4 commits into
aiming-lab:mainfrom
reacher-z:review/wineaccess-task-verifiers
Open

review(wineaccess): add deterministic task verifiers#81
reacher-z wants to merge 4 commits into
aiming-lab:mainfrom
reacher-z:review/wineaccess-task-verifiers

Conversation

@reacher-z

Copy link
Copy Markdown

Reviewer contribution

This builds on #75 while preserving Steven Dillmann's original WineAccess commit and authorship. The reviewer changes are isolated in a second commit.

What changed

  • added deterministic verifier entry points for all 18 WineAccess tasks
  • added task-specific navigation checks so a frozen answer without the required browser work fails
  • added SQLite before/after checks for all nine state-changing tasks: cart additions, saved-cellar addition, account preference update, club join, account creation at checkout, cart removal, and completed checkout
  • added exact seeded credentials to every standalone task that requires login
  • added explicit judge_rubric and verifier_path contracts without adding an answer key

Verification

  • python3 -m unittest discover -s sites/wineaccess/verify -p 'test_*.py' -v: 7 test groups pass
  • 18/18 positive cases pass
  • 18/18 no-op runs fail
  • 18/18 prior-knowledge shortcuts fail
  • 18/18 wrong-answer cases fail
  • 9/9 stateful claims fail when the live database is unchanged
  • all 18 verifier wrappers were exercised for pass and fail exit codes
  • py_compile and git diff --check pass
  • isolated WineAccess runtime health returned 60 wines; Contact and Where We Ship facts were confirmed through HTTP
  • a real Carol login + Connoisseurs Club join changed live SQLite from 0 to 1 matching membership and passed the task-10 verifier; the live DB was then reset byte-identically to the seed

Dependency

The underlying WineAccess mirror and its paired assets remain owned by #75 and its Hugging Face assets PR. This reviewer PR should be reviewed together with those source contributions; it does not claim their authorship.

@reacher-z
reacher-z force-pushed the review/wineaccess-task-verifiers branch from 76f3dfb to 75ff212 Compare August 18, 2026 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants