Fix release workflow: checkout repo before creating draft release - #39
Merged
Conversation
gh release create/view needs a git repo to infer the target repository; without a checkout step the prepare-release job failed with "fatal: not a git repository", skipping the whole matrix build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prepare-releasejob inrelease.ymlrangh release create/gh release viewwithout checking out the repo first, soghfailed withfatal: not a git repositorywhen trying to infer the target repo.Build & publishjobs before they ever expanded (https://github.com/ains/nota/actions/runs/29889556736/job/88827083604).actions/checkout@v7as the first step ofprepare-release, matching what the downstream matrix jobs already do.Test plan
v0.2.2) and confirmprepare-releasesucceeds and the macOS/Windows matrix jobs run.