Updated to newer cocos2d versions#2
Open
tebruno99 wants to merge 6 commits into
Open
Conversation
…r update method. The for loop constantly reiterated over every single item every frame. On long strings this caused frame rate to drop and to visually slow down as more characters became visible. Now you set text speed on init. TextBoxLayer text speed is now in seconds per character. So a value of 1 is 1 character every second. Value of 0.5f is 2 characters a second. TextBoxView's behavior for text speed was not changed.
…s completely viewable. Currently only implemented in TextBoxLayer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have patched TextBoxLayerSample to the latest Cocos2d 1.1beta2 version. There were changes to the way the size of each character were calculated. I broke the updated to 1.1beta2 and the patch to fix TextBoxLayer into different commits.