copy: rename expanded-notification "Now" label to "Live" (#196)#197
Closed
almothafar wants to merge 2 commits into
Closed
copy: rename expanded-notification "Now" label to "Live" (#196)#197almothafar wants to merge 2 commits into
almothafar wants to merge 2 commits into
Conversation
…194) Follow-up to #192. The ongoing status notification becomes a BigTextStyle two-state notification: - Collapsed: the volatile numbers on one line — rate/power · current · time, e.g. "9%/h · −250 mA · ~9h 27m remaining" / "~18 W · +2000 mA · ~1h 0m to full". Temperature moves to the expanded view; "left" → "remaining". - Expanded: a labelled breakdown — Now (instant current, + wattage while charging), Average (windowed-average current, carrying the smoothed %/h while discharging), Time remaining / Time to full, and Temperature. Each line is dropped when its data is absent; expansion is only offered when the breakdown is genuinely multi-line. The app has a single smoothed rate (itself an average), so there is no separate instantaneous %/h — the %/h rides the Average line rather than being faked onto a "Now" line. RTL: the Latin values (mA, %/h, watts, durations) are wrapped with BidiFormatter so they don't reorder inside an Arabic line (the garbling seen before). No-op in LTR. New labels reuse the details table's strings (Time remaining / Time to full / Temperature / Drain rate); new: Now, Average, and the "label: value" line format. All EN + AR (Arabic drafted, pending review). Tests: OngoingStatusLines reworked to 10 — collapsed (discharge/charge/no-current), expanded (discharge/charge/drain-rate-fallback), the built notification's BigText, temperature-only-and-not-expandable when the toggle is off, and null-snapshot. Closes #194 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The expanded status notification labels the live current line "Now", paired with "Average" below it. "Live" is a clearer contrast with "Average". Arabic "الآن" → "مباشر" (live, pairs with المتوسط). Only the string values change; the resource name notification_label_now and its usages are untouched, so tests are unaffected. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Owner
Author
|
Closing this — it should never have been opened. It was branched off a stale local |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #196.
The expanded status notification labels the live-current line "Now", paired with "Average" below it. "Live" is a clearer contrast with "Average".
"Current" was rejected — the value is the electrical current in mA, so "Current: −250 mA" would read as a mistake.
Only the string values change; the resource name
notification_label_nowand its usages (NotificationService.statusDetailExpanded,NotificationServiceTest) are untouched, so tests are unaffected.Verification
./gradlew :app:lintDebug→BUILD SUCCESSFUL, noMissingTranslation(Arabic parity intact).🤖 Generated with Claude Code