Repository navigation
Conversation
Contributor
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #524
Summary
Add context-menu actions to local file citations and recognized Markdown file links: open in the right-hand panel, copy the absolute path, and reveal in the OS file manager.
Bind filesystem actions to the source that actually supplied the preview (worktree, clone, artifacts, or absolute path). Preserve Git provenance; historical versions have no live filesystem actions, remote files have no local reveal, and a vanished selected worktree cannot silently fall back to another checkout.
Add artifact filename/relative-path search independent of the 2,000-entry tree cap, with cursor pagination. Selecting a result reveals it in the tree and opens its preview.
Show artifact root and selected-file paths with copy/reveal controls; add reveal to artifact file and folder menus. Search does not read file contents. No new dependencies.
Make slow searches resumable: pause after 5 seconds, ask before another 15 minutes, then ask again before removing the time limit. Keep traversal position, cancel obsolete searches, and limit physical search workers to two.
Test plan
cargo fmt --all --checkandcargo clippy --all-targets --locked -- -D warnings.cargo test --locked: 1,061 passed, 3 ignored (macOS; re-run after merging current main).pnpm build(including i18n lint/typecheck),pnpm lint:styles, andpnpm test: 224 passed. Regenerated committedui/dist.Added 8 frontend tests and 6 Rust tests for preview-source mapping/menu wiring, tree insertion, remote/workspace guards, async clipboard timing, search beyond the listing cap, pagination, and symlink/worktree confinement.
Local browser smoke test on an isolated synthetic demo: citation and Markdown-link menus resolve different correct roots; historical links omit OS actions; artifact name search, result selection/preview, root/file path controls, and file/folder menus (including Shift+F10).
Confirmed a fixture absent from the truncated API listing (
qa-524/bulk/entry-0044.txt) is found by UI search, selected in the tree, and previewed.Review regressions: externally removing a selected search hit clears its row/preview; metadata failures mark results incomplete. In the real local UI, verified a timed pause over a large synthetic tree, continue-to-completion, and cancel without an automatic restart.
Automated tests cover both budget transitions, saved traversal state, lease expiry, and cancellation of late/in-flight responses. The 15-minute-to-unlimited transition was tested without waiting 15 minutes in the browser.
Merged upstream main at
951700e: preserved project-root reveal and source-aware file guards, added the new feature strings to the Japanese and Korean catalogs, and rebuilt committedui/distfrom the merged sources. A second build produced identical assets. Re-ran the full Rust/UI suites and verified artifact search, result selection/preview, path resolution, and the artifact file menu in the isolated dev UI. The copy-path action completed successfully in the embedded browser. Initial search budget remains 5 seconds.Verification limits: remote behavior is covered by mocked frontend tests, not a new SSH end-to-end run. Finder's actual file-selection behavior was not verified because macOS automation permissions prevented observing it. Clipboard tests verify invocation timing, not browser-specific permission behavior. Windows/Linux OS integration was not run locally. Cancellation is cooperative: an already blocked filesystem syscall cannot be interrupted; no faulty network filesystem was exercised.
Screenshots
Captured from the isolated demo with synthetic files. In order: chat file menu; artifact search; artifact path details; artifact file menu; artifact folder menu.




