Repository navigation
OR-423 Install Git and OpenCode reliably on Windows - #540
Merged
Merged
Conversation
Re-read the registry PATH so a Git installed while orx runs is found, offer an orx-installed PortableGit in onboarding, download OpenCode via the system proxy with an npm fallback, and keep the install script's own text out of setup telemetry. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…h steps Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…oarding # Conflicts: # README.md # ui/dist/assets/PdfPreview-CUNM1AGl.js # ui/dist/assets/PdfPreview-Cv4PDQEo.js # ui/dist/assets/PdfPreview-DTe4mY-0.js # ui/dist/assets/index-n2QHfWHn.js # ui/dist/index.html
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
RegGetValueW can report an expanded value's size past its terminator, which left a NUL in the PATH orx hands every child, so every spawn failed with "nul byte found in provided data". Also log Git install failures. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows onboarding finishes far less often than on macOS and Linux. The biggest drop is the automatic OpenCode install, which runs when no agent is detected: 53% of those Windows installs finish onboarding, against 86–87% on macOS and Linux. The OpenCode download from GitHub fails on network errors, but telemetry labelled those failures "Unsupported architecture". Git is also a hard requirement, and onboarding could only say "Install Git, then re-check".
What changes
install_opencode.ps1): it now tries three sources in order:Invoke-WebRequest, which uses the system proxy and handles certificate revocation checks on filtered networks, unlikecurl.exe. It also forces TLS 1.2 and turns off the progress bar.opencode-windows-<arch>), checked against npm's SHA-512 and unpacked with Windows' owntar.exe. No Node is needed.curl.exepath.Write-Errorand the console title), so allowlisted phrases inside it, like its never-taken "Unsupported architecture" branch, became every failure's excerpt.-EncodedCommandand writes errors straight to stderr.shell_env::search_path): on Windows, orx now also reads the registry's current PATH, so no restart is needed.portable_git.rs,POST /api/git/install):%LOCALAPPDATA%\OpenResearch\PortableGit, with no admin prompt and no PATH change.The
cfg(windows)code has only been checked by reading it; Windows CI is its first compile.Test plan
cargo fmt --all --check,cargo clippy --all-targets -D warnings,cargo build --locked,cargo test --locked(macOS)tsc --noEmit,vite build, UI unit tests (216 pass);ui/distrebuiltdigestfields, npm tarball layout-o"<dir>"quoting); no lingering console window🤖 Generated with Claude Code