Repository navigation
Report the orx up backend version in orx feedback - #544
Merged
Merged
Conversation
Contributor
Author
|
@greptileai review |
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
orx feedbacknow sendscontext.backendVersion, which is the version of theorx upthat spawned the agent. The existingcliVersionfield is still sent. Before this change, a report only showed the version of theorxbinary that the agent found on PATH. The sandbox and harness that the report is about are configured by the long-running backend, and that backend can be a different version. Two recent reports (cliVersion 0.2.16 and 0.2.14) came from installs whose backend was 0.2.10. That led triage to reopen OR-335 by mistake.ORX_UP_VERSION, whichset_chat_session_envalready exports to harness children whenever anorx upport is present (added in Restart idle orx up after auto-update (OR-334, OR-335) #485, shipped in v0.2.15).harnessset but nobackendVersion, the backend is older than 0.2.15.Companion change needed (openresearch.sh)
zFeedbackContextinapi/src/lib/schemas.tsis a plainz.object. It strips unknown keys. Until the field below is added, the API accepts these reports but silently dropsbackendVersion. Shipping this side first is safe.backendVersion: z.string().max(64).optional()tozFeedbackContext.feedback-slack.steps.ts.Test plan
cargo fmt --all --check,cargo clippy --all-targets -- -D warnings,cargo build --locked,cargo test --lockedbackendVersionserializes in camelCase.orx upran a probe. The agent's env hadORX_UP_VERSION=0.2.16. A locally built production-channelorx feedbacksent"backendVersion":"0.2.16"to a loopback capture stub. Nothing was sent to production.orx feedback(noorx upparent) leaves outbackendVersion. WithORX_UP_VERSION=0.2.10forced, it sends"cliVersion":"0.2.16","backendVersion":"0.2.10".context.backendVersion.