Skip to content

Report the orx up backend version in orx feedback - #544

Merged
sox8502 merged 1 commit into
mainfrom
daniel/feedback-backend-version
Oct 6, 2026
Merged

sox8502 merged 1 commit into
mainfrom
daniel/feedback-backend-version

Conversation

@sox8502

@sox8502 sox8502 commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Summary

orx feedback now sends context.backendVersion, which is the version of the orx up that spawned the agent. The existing cliVersion field is still sent. Before this change, a report only showed the version of the orx binary that the agent found on PATH. The sandbox and harness that the report is about are configured by the long-running backend, and that backend can be a different version. Two recent reports (cliVersion 0.2.16 and 0.2.14) came from installs whose backend was 0.2.10. That led triage to reopen OR-335 by mistake.

  • This PR adds no new env var. It reads the existing ORX_UP_VERSION, which set_chat_session_env already exports to harness children whenever an orx up port is present (added in Restart idle orx up after auto-update (OR-334, OR-335) #485, shipped in v0.2.15).
  • If the variable is missing or empty, the field is left out. That happens in standalone CLI use, and when the backend is older than v0.2.15. So if a report from a chat has harness set but no backendVersion, the backend is older than 0.2.15.

Companion change needed (openresearch.sh)

zFeedbackContext in api/src/lib/schemas.ts is a plain z.object. It strips unknown keys. Until the field below is added, the API accepts these reports but silently drops backendVersion. Shipping this side first is safe.

  • Add backendVersion: z.string().max(64).optional() to zFeedbackContext.
  • Optionally show it in the Slack line in feedback-slack.steps.ts.

Test plan

  • cargo fmt --all --check, cargo clippy --all-targets -- -D warnings, cargo build --locked, cargo test --locked
  • Unit test: the wire-shape test asserts backendVersion serializes in camelCase.
  • E2E, isolated dev slot (empty DB): a Codex chat under the slot's orx up ran a probe. The agent's env had ORX_UP_VERSION=0.2.16. A locally built production-channel orx feedback sent "backendVersion":"0.2.16" to a loopback capture stub. Nothing was sent to production.
  • Standalone orx feedback (no orx up parent) leaves out backendVersion. With ORX_UP_VERSION=0.2.10 forced, it sends "cliVersion":"0.2.16","backendVersion":"0.2.10".
  • After the openresearch.sh schema change deploys: a real report stores context.backendVersion.

@sox8502

sox8502 commented Oct 6, 2026

Copy link
Copy Markdown
Contributor Author

@greptileai review

@greptile-apps

greptile-apps Bot commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Low risk] Adds backend version field to feedback telemetry.

This PR appears safe to merge.

What we checked:

  • Reports use the running backend: Supported chat launches replace the inherited value with the running backend’s compiled version. Launches without a backend port remove the value.

Summary

orx feedback now includes context.backendVersion from ORX_UP_VERSION, while preserving cliVersion.

  • Missing or empty values leave the new field out.
  • The wire-shape test checks the camelCase field name.
  • sox8502 explicitly acknowledged that the companion API drops the field until its separate schema change deploys.

Reviews (1) · Last reviewed commit: "Report the orx up backend version in orx..."

@sox8502
sox8502 merged commit e4bf772 into main Oct 6, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant