Repository navigation
Re-pin the vendored cdifTabularData: the counts now carry a propertyID - #55
Merged
Merged
Conversation
Takes mBB 7052e52a0 (its PR #48) into vendor/remote/ and re-resolves. countRows and countColumns were bare unprefixed integers on the tabular distribution -- the only two unprefixed properties among twenty-one prefixed siblings in the composed adaProduct -- and upstream they are now schema:additionalProperty PropertyValue entries whose schema:propertyID names the concept each quantifies, DDI DISCOVERY caseQuantity for rows and variableQuantity for columns. The vendored diff is exactly that one upstream change: +15 -5 in vendor/remote/.../cdifDataType/cdifTabularData/schema.yaml and nothing else. Eight other vendored files show as modified in `git status` and have ZERO content diff -- the usual CRLF stat churn, and I mis-read it as nine real upstream changes before checking `git diff --numstat`. The lock file re-pins 49 remote schemas. Downstream: 82 resolvedSchema.json files, +10490 -4100, and 0 bare countRows/countColumns declarations remain anywhere in _sources. The census found a loss and it is worth recording why it is not one. 76 blocks each report `-1 closed`. Cause: two INLINE copies of the propertyID anyOf -- one under prov:wasGeneratedBy, one in $defs/Instrument_AdditionalProperty -- collapsed into a single shared $defs/propertyID_item, because the upstream change introduced that as a NAMED $def and the resolver now promotes it once instead of inlining it twice. The closure is intact on the shared def (type=object, required=['@id'], additionalProperties=false) and THREE sites now $ref it, the two former inline ones plus the new CdifTabularData_AdditionalProperty. One definition serving three sites where two were duplicated: strictly better coverage, one fewer counted node. That is the census behaving as designed. 638 examples pass either way, so nothing else in the pipeline would have raised this; the count made me look and the investigation showed it benign. Worth knowing as a standing characteristic: deduplicating an inline constraint into a shared $def registers as a loss, because the census counts definitions and not the sites reached through them. validate_examples 638 passed, 0 failed validate_counterexamples 13/13 still rejected constraint_census 247 blocks, 1355952 -> 1357968; baseline updated with --write in this commit Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Takes mBB
7052e52a0(their #48) intovendor/remote/and re-resolves.countRows/countColumnswere bare unprefixed integers on the tabular distribution — the only two unprefixed properties among twenty-one prefixed siblings in composedadaProduct. Upstream they are nowschema:additionalPropertyPropertyValueentries whoseschema:propertyIDnames the concept each quantifies: DDI DiscoverycaseQuantityfor rows,variableQuantityfor columns.The vendored diff is only that change
+15 −5invendor/remote/.../cdifDataType/cdifTabularData/schema.yaml, and nothing else. Eight other vendored files appear modified ingit statuswith zero content diff — the usual CRLF stat churn. I mis-read that as nine real upstream changes before checkinggit diff --numstat; worth stating because the vendoring design exists precisely so an unannounced upstream change can't hide in a large diff.The lock re-pins 49 remote schemas. Downstream: 82
resolvedSchema.json,+10490 −4100, and 0 barecountRows/countColumnsdeclarations remain anywhere in_sources.The census found a "loss" — and it isn't one
76 blocks each report
-1 closed. Cause: two inline copies of the propertyIDanyOf— one underprov:wasGeneratedBy, one in$defs/Instrument_AdditionalProperty— collapsed into a single shared$defs/propertyID_item, because the upstream change introduced that as a named$defand the resolver now promotes it once instead of inlining it twice.Verified the closure survives:
One definition serving three sites where two were duplicated — strictly better coverage, one fewer counted node.
This is the census working as intended. 638 examples pass either way, so nothing else in the pipeline would have raised it; the count made me look, and looking showed it benign. Worth recording as a standing characteristic: deduplicating an inline constraint into a shared
$defregisters as a loss, because the census counts definitions, not the sites reached through them.Verification
validate_examplesvalidate_counterexamplesconstraint_census--writein this commitgBB uses these properties in 0 of its own examples, so no example needed rewriting here — the change is schema-only on this side.
amds-ldeo/metadatastill has two subject-key rows (939 records each) pointing at the old bare path, which is that session's follow-up.🤖 Generated with Claude Code