Skip to content

sc5xx remoteproc cleanups - #3509

Open
ukleinek wants to merge 5 commits into
analogdevicesinc:adsp-6.18.31-yfrom
ukleinek:sc5xx
Open

sc5xx remoteproc cleanups#3509
ukleinek wants to merge 5 commits into
analogdevicesinc:adsp-6.18.31-yfrom
ukleinek:sc5xx

Conversation

@ukleinek

Copy link
Copy Markdown
Collaborator

PR Description

Simplify and cleanup the drivers related to remoteproc operation. While working on these and understand their functions, simplifications help a lot make the picture clearer (and identify layer violations :-)).

PR Type

  • Bug fix (a change that fixes an issue)
  • New feature (a change that adds new functionality)
  • Breaking change (a change that affects other repos or cause CIs to fail)

PR Checklist

  • I have conducted a self-review of my own code changes
  • I have compiled my changes, including the documentation
  • I have tested the changes on the relevant hardware
  • I have updated the documentation outside this repo accordingly
  • I have provided links for the relevant upstream lore

The three function adi_tru_set_trigger(), adi_tru_set_trigger_by_id()
and adi_tru_trigger() are used only internally, so mark the functions
static.

adi_tru_trigger() is used by adi_tru_trigger_device(), so their order
has to be swapped to not need a function declaration.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
The functions adi_rcu_check_coreid_valid(), adi_rcu_reset_core(),
adi_rcu_start_core() and adi_rcu_stop_core() are only used within the
compile unit and so can be static and don't need to be exported.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
Both get_adi_sec_from_node() and put_adi_sec() are not used, and never
were since they were introduced. So drop them.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
@ukleinek
ukleinek requested a review from pamolloy August 25, 2026 11:16
@ukleinek ukleinek self-assigned this Aug 25, 2026
There is only a single .c file which only consists of #include
statements. There is no code generated and throwing that away doesn't
hurt. So do that.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
@pamolloy pamolloy added this to ADSP Aug 25, 2026
@pamolloy
pamolloy requested a review from a team August 25, 2026 14:16
@pamolloy pamolloy added the llm review Request a review from a LLM Reviewer label Aug 25, 2026
@github-actions

github-actions Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

LLM review

This series is a janitorial cleanup of drivers/soc/adi/ (ADI SC5xx/SC59x mach code): marking
internally-used functions static, dropping unused exports, fixing a comment typo, and removing
the now-empty mach-sc59x/ directory.

Session: 32858449430

540f215d0ad6 - Drop empty mach-sc59x

Orphaned Kconfig symbol: drivers/soc/adi/mach-sc59x/{Makefile,core.c,core.h} and the
obj-$(CONFIG_ADI_MACH_SC59X) line are removed, but config ADI_MACH_SC59X is left in
drivers/soc/adi/Kconfig. A tree-wide grep shows nothing selects or references it any more, so it
is now a dead Kconfig option (still shown/settable, builds nothing). It should be dropped in the
same commit for consistency with the stated goal ("throwing that away doesn't hurt").

The b42d5e4fe4a1, 2b15323b3c0a, 7928f7431db7 (static/unused-function) and cbbd3d76ae76
(typo) commits were checked for external callers of the touched/removed functions across the
whole tree; none exist, so these are safe.

CI warnings

Both checkpatch warnings in the CI log are non-issues:

  • "added, moved or deleted file(s), does MAINTAINERS need updating?" on 540f215d0ad6: the
    MAINTAINERS entry F: drivers/soc/adi/ already covers the removed mach-sc59x/ subdirectory
    as a wildcard, so no update is needed.
  • "Missing commit description" on cbbd3d76ae76: cosmetic, the subject already fully describes
    the one-line typo fix.

Verification data

  • Built drivers/soc/adi/ clean (no warnings) for arm64 (sc598-som-ezkit_defconfig) and arm
    (sc594-som-ezkit_defconfig) with set_arch gcc_aarch64 / set_arch gcc_arm.
  • grep -rn across the tree confirmed no external users of the functions turned static or
    removed.
  • Confirmed ADI_MACH_SC59X is unreferenced anywhere except its own now-orphaned config block,
    while ADI_MACH_SC5XX is still legitimately used by drivers/rpmsg/Kconfig and
    drivers/remoteproc/Kconfig.

Suggested patches

Apply the suggested patches with:

cd path/to/repository
export GITHUB_TOKEN=ghp_***
apply-patches --repo=analogdevicesinc/linux 32858449430
Install instructions

The following one-liner installs the script if not present already:

curl -fSsL "https://raw.githubusercontent.com/analogdevicesinc/doctools/refs/heads/main/ci/scripts/apply-patches.sh"      -o ~/.local/bin/apply-patches.sh &&   grep -q "/apply-patches.sh" ~/.bashrc || echo "source ~/.local/bin/apply-patches.sh" >> $_ ; . $_

More information at AI Usage.

@analogdevicesinc analogdevicesinc deleted a comment from github-actions Bot Aug 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

llm review Request a review from a LLM Reviewer

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants