Skip to content

⚡ Bolt: Optimize section header prefix checking - #422

Open
anchapin wants to merge 1 commit into
mainfrom
bolt/optimize-startswith-5897188167847207126
Open

⚡ Bolt: Optimize section header prefix checking#422
anchapin wants to merge 1 commit into
mainfrom
bolt/optimize-startswith-5897188167847207126

Conversation

@anchapin

@anchapin anchapin commented Jul 21, 2026

Copy link
Copy Markdown
Owner

💡 What: Change section_header_starts to a tuple and pass it directly to startswith().\n🎯 Why: Using a tuple with startswith pushes the iteration to optimized C code, avoiding the O(N) overhead of generator expressions inside loops.\n📊 Impact: Speeds up prefix matching significantly on large texts.\n🔬 Measurement: Run the test suite and observe no functional changes while text processing speed increases.


PR created automatically by Jules for task 5897188167847207126 started by @anchapin

Summary by Sourcery

Enhancements:

  • Switch section header prefixes to a tuple and use startswith with the tuple for faster C-level prefix matching in job text parsing.

Switched from `any(line.startswith(h) for h in list)` to
`line.startswith(tuple)`, pushing iteration to C layer.
Removed redundant derivative checks (`header + ":"`).

Co-authored-by: anchapin <6326294+anchapin@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@sourcery-ai

sourcery-ai Bot commented Jul 21, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Optimizes section header detection in the job parser by converting the header keyword collection to a tuple and using startswith() directly, changing how section-like lines are filtered while improving performance in large text parsing loops.

File-Level Changes

Change Details Files
Optimize section header prefix checking and slightly alter the matching semantics in the job text extraction loop.
  • Change section_header_starts from a list to a tuple so it can be passed directly to str.startswith for C-level iteration over prefixes.
  • Replace the generator-expression-based any(...) check with a single line_lower.startswith(section_header_starts) call.
  • Remove the explicit checks for header + ':' suffix, meaning lines starting with header keywords followed immediately by a colon are now treated the same as other prefixed lines based solely on the provided tuple.
cli/integrations/job_parser.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The new startswith(section_header_starts) logic drops the previous header + ':' handling, so lines like requirements: or responsibilities: will now be treated as bullets instead of headers; consider preserving the colon variants or documenting this behavioral change explicitly.
  • If section header prefixes are static, consider moving section_header_starts to a module-level constant so the tuple isn’t recreated on every _extract_items_from_text call, which better aligns with the performance optimization goal.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The new `startswith(section_header_starts)` logic drops the previous `header + ':'` handling, so lines like `requirements:` or `responsibilities:` will now be treated as bullets instead of headers; consider preserving the colon variants or documenting this behavioral change explicitly.
- If section header prefixes are static, consider moving `section_header_starts` to a module-level constant so the tuple isn’t recreated on every `_extract_items_from_text` call, which better aligns with the performance optimization goal.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant