⚡ Bolt: Cache lowercased strings outside loops to prevent redundant O(N) allocations

[anchapin]

💡 What: Cache lowercased strings outside of any() comprehensions to prevent redundant allocations. 🎯 Why: String methods evaluated on the right side of comprehensions are evaluated repeatedly for every iteration in the sequence, causing O(N) memory allocations. 📊 Impact: Improves performance when filtering elements. 🔬 Measurement: Observe faster filtering execution and lower memory usage.

---

PR created automatically by Jules for task 11631676232225525544 started by @anchapin

Summary by Sourcery

Optimize keyword and skill matching in YAML parsing by avoiding repeated string lowercasing inside loops.

Enhancements:

• Cache lowercased skill names before matching against technologies to reduce repeated allocations.
• Precompute lowercased emphasize keywords and bullet text for experience filtering to improve performance.

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR optimizes string matching in the YAML parser by caching lowercased strings outside of loops and comprehensions to avoid repeated O(N) allocations during filtering operations.

File-Level Changes

Change	Details	Files
Cache lowercased skill names before membership checks in technology list to avoid repeated lowercasing inside the loop.	Introduce a skill_name_lower variable computed once per skill iteration. Update any() comprehension to use the precomputed lowercase skill name for membership tests against tech_lower. Retain existing matching/non_matching behavior while improving performance.	cli/utils/yaml_parser.py
Precompute lowercased emphasize keywords and bullet text before keyword matching to reduce repeated allocations.	Add emphasize_keywords_lower list derived from emphasize_keywords before iterating over experience. Introduce a text_lower variable computed once per bullet within the job loop. Modify the any() condition to check pre-lowered keywords against pre-lowered bullet text, preserving existing filtering logic.	cli/utils/yaml_parser.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• The new emphasize_keywords_lower = [kw.lower() for kw in emphasize_keywords] assumes all entries are strings; consider guarding against non-string values (e.g., None or dicts) to avoid runtime errors when parsing unexpected YAML.
• The inline comments about preventing redundant O(N) allocations could be clarified to more precisely describe the optimization (e.g., avoiding repeated str.lower() calls per iteration) rather than suggesting allocations scale with loop length.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The new `emphasize_keywords_lower = [kw.lower() for kw in emphasize_keywords]` assumes all entries are strings; consider guarding against non-string values (e.g., `None` or dicts) to avoid runtime errors when parsing unexpected YAML.
- The inline comments about preventing redundant O(N) allocations could be clarified to more precisely describe the optimization (e.g., avoiding repeated `str.lower()` calls per iteration) rather than suggesting allocations scale with loop length.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}