⚡ Bolt: Cache lowercased strings outside loops to prevent redundant O(N) allocations

[anchapin]

💡 What: Cache lowercased strings outside loops and generator expressions.
🎯 Why: Prevent redundant O(N) memory allocations.
📊 Impact: Reduced memory overhead and slight execution time improvements.
🔬 Measurement: Ran test suite with python -m pytest to verify no functionality regressions.

---

PR created automatically by Jules for task 8610256534818665167 started by @anchapin

Summary by Sourcery

Optimize string matching paths by caching lowercased values outside hot loops and generator expressions to reduce redundant allocations and improve performance.

Enhancements:

• Cache lowercased skill names and emphasize keywords once per iteration in YAML parsing instead of recomputing inside generator expressions.
• Rely on pre-lowercased resume text in ATS readability scoring to avoid unnecessary string transformations.
• Document the performance pattern of avoiding redundant lowercasing in comprehensions in the Bolt optimization guide.

Documentation:

• Add a Bolt entry describing redundant lowercasing in generator expressions and the preferred caching pattern to avoid extra allocations.

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR optimizes string handling in hot paths by caching lowercased versions of strings outside loops and comprehensions, and documents the performance lesson in the Bolt playbook.

Flow diagram for cached lowercasing in get_experience keyword matching

flowchart TD
    A[Start get_experience] --> B[Load emphasize_keywords]
    B --> C[Compute emphasize_keywords_lower]
    C --> D[Iterate bullets]
    D --> E[Read bullet.text]
    E --> F[Compute text_lower]
    F --> G{variant in emphasize_for
            OR any kw in text_lower
            for kw in emphasize_keywords_lower}
    G -->|True| H[Append bullet to filtered_bullets]
    G -->|False| I[Skip bullet]
    H --> J[Return filtered_experience]
    I --> J[Return filtered_experience]

Loading

File-Level Changes

Change	Details	Files
Cache lowercased skill names once per iteration instead of repeatedly in the membership check loop.	Introduce a skill_name_lower variable computed once per skill. Use skill_name_lower in the technology matching any() expression instead of calling skill_name.lower() inline.	cli/utils/yaml_parser.py
Precompute a lowercased emphasize_keywords list and reuse a lowercased bullet text for keyword matching.	Create emphasize_keywords_lower as a pre-lowered list of emphasize_keywords before iterating over experience. Cache text_lower per bullet and use it in the keyword match any() expression instead of repeatedly calling text.lower().	cli/utils/yaml_parser.py
Clarify that resume text is already lowercased, avoiding redundant lowercasing in action verb counting.	Remove the all_text.lower() call inside the sum comprehension for action_verb_count. Add comments explaining that all_text is already lowercased by _get_all_text and that we are caching lowercased strings outside loops.	cli/generators/ats_generator.py
Add a Bolt performance note documenting the pattern of caching lowercased strings outside loops or comprehensions.	Document the learning about redundant lowercasing in generator expressions and its impact on memory and CPU. Prescribe caching of expensive string transformations outside loops as a standard optimization practice.	.jules/bolt.md

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• In _check_readability, the change relies on _get_all_text always returning a lowercased string; consider either keeping the .lower() call for safety or enforcing/clarifying this contract (e.g., via the helper’s name or an assertion) to avoid subtle bugs if _get_all_text changes in future.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- In `_check_readability`, the change relies on `_get_all_text` always returning a lowercased string; consider either keeping the `.lower()` call for safety or enforcing/clarifying this contract (e.g., via the helper’s name or an assertion) to avoid subtle bugs if `_get_all_text` changes in future.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}