🛡️ Sentinel: [CRITICAL] Fix PDF Compilation RCE and DoS vulnerabilities

[anchapin]

🚨 Severity: CRITICAL
💡 Vulnerability: Subprocess calls to pdflatex and pandoc lacked -no-shell-escape flag and timeout limits in converter.py and cover_letter_generator.py.
🎯 Impact: Malicious LaTeX input could execute arbitrary system commands (RCE) or cause infinite loops (DoS).
🔧 Fix: Added -no-shell-escape flag, --pdf-engine-opt=-no-shell-escape flag, and timeout=30 with proper process cleanup across all PDF generation functions.
✅ Verification: The test suite passes and verified manually that arguments are passed correctly.

---

PR created automatically by Jules for task 10004504771424974871 started by @anchapin

Summary by Sourcery

Harden PDF generation against RCE and DoS by securing all pdflatex and pandoc invocations and updating internal security documentation.

Enhancements:

• Add -no-shell-escape flags and 30-second timeouts to all pdflatex and pandoc subprocess calls used for PDF compilation to prevent command execution and runaway processes.

Documentation:

• Document the PDF compilation RCE and DoS vulnerability, mitigation, and prevention guidance in the Sentinel security notes.

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[sourcery-ai]

Sorry @anchapin, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

[sourcery-ai]

Reviewer's Guide

Locks down PDF generation against LaTeX-based RCE/DoS by adding -no-shell-escape flags and 30s timeouts to all pdflatex/pandoc subprocess invocations, with proper cleanup on timeout, and documents the incident in the Sentinel security log.

File-Level Changes

Change	Details	Files
Harden pdflatex and pandoc invocations in cover letter PDF generation against RCE and DoS.	Add -no-shell-escape flag to pdflatex command used for compiling cover letter PDFs Add --pdf-engine-opt=-no-shell-escape to pandoc-based PDF compilation fallback Wrap subprocess.communicate calls with a 30-second timeout, killing the process and returning False on timeout Preserve existing stdout/stderr capture and success checks while integrating the new timeout logic	cli/generators/cover_letter_generator.py
Apply the same pdflatex/pandoc hardening to the generic PDF converter.	Add -no-shell-escape flag to pdflatex command in the shared PDF converter Add --pdf-engine-opt=-no-shell-escape to pandoc command in the shared PDF converter Introduce 30-second communicate timeouts for both pdflatex and pandoc, killing the process and returning False when exceeded Retain existing working_dir usage, stdout/stderr capture, and output existence checks	cli/pdf/converter.py
Document this PDF compilation security fix in the Sentinel security record.	Add a new Sentinel entry describing the missing -no-shell-escape/timeout vulnerability Document the learning around consistent enforcement of security flags for external engines Record prevention guidance to centralize or systematically enforce secure pdflatex/pandoc invocations	.jules/sentinel.md

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.