⚡ Bolt: Cache lowercased strings outside comprehensions to prevent O(N) allocations

[anchapin]

💡 What: Extracted all_text.lower() out of the generator expression in cli/generators/ats_generator.py _check_readability. 🎯 Why: The previous code evaluated .lower() for every item in action_verbs, leading to redundant O(N) allocations for a large string. 📊 Impact: Prevents unnecessary memory allocations and CPU cycles, improving execution speed of readability checks. 🔬 Measurement: Run the test suite and observe no functional regressions.

---

PR created automatically by Jules for task 8239027801753157274 started by @anchapin

Summary by Sourcery

Enhancements:

• Cache the lowercased resume text once in _check_readability instead of recomputing it for each action verb.

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Caches the lowercased resume text once in the ATS readability check to avoid repeated O(N) string allocations inside a generator expression, improving performance without changing behavior.

Flow diagram for cached lowercased text in _check_readability

flowchart TD
    A[_check_readability resume_data] --> B[collect all_text]
    B --> C[compute all_text_lower = all_text.lower]
    C --> D[iterate action_verbs]
    D --> E[increment action_verb_count if verb in all_text_lower]
    E --> F[[check if action_verb_count >= 3]]
    F -->|yes| G[append readability detail]
    F -->|no| H[skip detail]

Loading

File-Level Changes

Change	Details	Files
Cache the lowercased resume text before iterating over action verbs to avoid repeated .lower() calls.	Introduce an all_text_lower variable holding all_text.lower() Update the action_verb_count generator expression to search in all_text_lower instead of all_text.lower() Add a brief code comment explaining the caching rationale to future readers	cli/generators/ats_generator.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• Since this is a performance-focused change, consider whether using casefold() instead of lower() would be more robust for non-ASCII text without materially affecting performance.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Since this is a performance-focused change, consider whether using `casefold()` instead of `lower()` would be more robust for non-ASCII text without materially affecting performance.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}