Fix Android Virtual Swapchain ANativeWindow collision after AdHoc presentation - #19
Open
olehkuznetsov wants to merge 1 commit into
Open
Fix Android Virtual Swapchain ANativeWindow collision after AdHoc presentation#19olehkuznetsov wants to merge 1 commit into
olehkuznetsov wants to merge 1 commit into
Conversation
olehkuznetsov
force-pushed
the
experiment2
branch
from
July 31, 2026 14:16
7288234 to
04778a0
Compare
…sentation When replaying Android traces, the replay runtime sometimes utilizes an AdHoc surface presentation layer to visualize headless loading phases. However, in the original architecture, this AdHoc surface held onto system OS Window resources permanently. When the trace finally attempted to create its genuine swapchain surface (e.g. vkCreateAndroidSurfaceKHR), it would fail with VK_ERROR_NATIVE_WINDOW_IN_USE_KHR because the window was still bound to the AdHoc surface. Changes: - Overrode CreateSurface in VulkanVirtualSwapchain to intercept the application's genuine hardware surface request. - When a real surface is requested, we now preemptively clear the internal adhoc_device_data_ and gracefully release the underlying ANativeWindow before delegating instantiation back to the base class. - Introduced application_surface_created_ latch to permanently halt artificial AdHoc FrameBoundary renders once the application trace has successfully transitioned to rendering its own native pipeline.
olehkuznetsov
force-pushed
the
experiment2
branch
from
July 31, 2026 14:17
04778a0 to
d5403b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...