Repository navigation
CI: run the install and start check on the newest Node release too - #20
Merged
Merged
Conversation
The workflow's comment said the newest Node line gets the install and start check, but the leg ran Node 24, and Node 26 is the newest line: 26.13.0 is its current release (nodejs.org's dist/index.json). The check now runs on Node 24, an LTS line in maintenance until 2028-04-30, and on the newest release, which setup-node gives for 'latest', where a new Node breaking install or start would show first. The 22.0.0 leg, engines' floor, is unchanged, and the comment names all three.
nissa-seru
pushed a commit
to nissa-seru/github-mcpl
that referenced
this pull request
Oct 28, 2026
main now runs CI the testing setup's way (anima-research#19, anima-research#20): the whole suite once at a pinned Node, and an install and start check on engines' floor, Node 24 and the newest Node release. With engines at >=22.12.0 here, the resolution keeps that shape at this branch's floor: - The suite job runs at Node 22.12.0, engines' floor, in place of this branch's Node 22 and 24 matrix of whole suites. - The install and start check runs on Node 24 and on the newest release. main's 22.0.0 leg checked the old floor; the floor is now 22.12.0, where the suite job runs. - README's development line keeps this branch's "Node 22.12 or newer", which covers npm test as well as the server.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a third leg to github-mcpl's install and start check in CI, on the newest Node release, beside Node 22.0.0 and Node 24, and makes the workflow's comment name all three legs. Nothing a user, operator or host of the server meets changes.
Problem
At
main(4b5244d), the comment over the CI jobs says that "engines' floor, 22.0.0, and the newest Node line get the install and start check below" (.github/workflows/ci.yml:15–:16). The check's matrix is['22.0.0', '24'](:51), and onmain's last CI run (run 40771502205) the second leg ran Node v24.22.1. Node 26 is the newest line: nodejs.org'sdist/index.jsonlists v26.13.0, released October 28, 2026, first. Node's release schedule (nodejs/Release,schedule.json) has Node 24 in maintenance since October 20, 2026, and supported until April 30, 2028.Changes
.github/workflows/ci.yml: the install and start check's matrix becomes['22.0.0', '24', 'latest']. The third leg, "Install & Start (node latest)", gives setup-nodenode-version: latest, and runs the same steps as the other two:npm ci,npm run buildandnode scripts/ci-start-check.mjs. The comment over the jobs now says the check runs on engines' floor, 22.0.0, on Node 24, "a maintenance LTS line hosts still run", and on the newest Node release. The whole-suite job is unchanged.Tests
On Linux x86_64, in a clean checkout of this head, with Node 26.13.0 from nodejs.org's
linux-x64build and its npm 11.20.0:npm ciandnpm run buildsucceeded, and the start check printed "ci-start-check (Node v26.13.0): the built server answered initialize over --stdio and exited 0", with exit 0.Not verified
latestitself. CI runs the new leg first on this pull request, so which release it installs shows there.With other open pull requests
By
git merge-treeagainstmain4b5244dand each open pull request's head:main, and with this change, in.github/workflows/ci.ymlandREADME.md.#11merge cleanly with both.#4and#6conflict withmain, and with this change, in the same files.No changelog fragment: this changes CI only.
Ogden-2688 made this change, and Agnes-984 made the calls on it. Esther-2584 read it. Fiona-2757 wrote this description.