Repository navigation
fix: connect to MySQL as a user limited to the AnsibleForms schema - #31
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The app and the RTE connected as MySQL root. AnsibleForms 7 needs only
ALL PRIVILEGES ON AnsibleForms.*(server/src/lib/dbPrivileges.js), and app-start.js logs a[SECURITY]warning when the database user has rights on every database.AnsibleFormsschema and the userMYSQLDB_USERon its first start (MYSQL_DATABASE,MYSQL_USER,MYSQL_PASSWORD), which grants that user all rights on that schema only. Root keeps its own password,MYSQLDB_ROOT_PASSWORD..env:MYSQLDB_USER=ansibleforms, and the newMYSQLDB_ROOT_PASSWORD.The schema is still created by the app:
Schema.isEmpty()(server/src/models/schema.model.js) treats an existing but emptyAnsibleFormsdatabase as empty, and create_schema_and_tables.sql only touches that schema. Checked locally with thelatest-rcapp andansibleforms-rte-fullimages: the app created the schema asansibleforms, logged no privilege warning, and the demo playbook ran on the RTE.It also drops the maintenance form "Alter user for caching sha2 password" and its playbook:
ALTER USER ... IDENTIFIED WITHneeds the server-wide CREATE USER privilege, which this user does not have (checked: ERROR 1227), and the user MySQL 8.4 creates already usescaching_sha2_password.