Skip to content

fix: keep the language in the steps, and go back to it with Esc - #12

Merged
blaipr merged 1 commit into
mainfrom
fix/language-step-stays
Oct 19, 2026
Merged

blaipr merged 1 commit into
mainfrom
fix/language-step-stays

Conversation

@blaipr

@blaipr blaipr commented Oct 19, 2026

Copy link
Copy Markdown
Member

What this changes

  • The Language step stays in the left menu once answered. It is asked before the installer looks for an installation, so the wizard skipped its own language step, and a skipped step left the menu. The same in an upgrade reached from the install.
  • Esc on the release notes goes back to the language, in the install and in the upgrade, then shows the notes again.

Checklist

  • Branch is named <type>/<description> and the title is a Conventional Commit
  • gofmt -l . prints nothing, and go vet ./... and go test ./... pass (new tests for the menu and for Esc back to the language)
  • Tried the changed flow with the built binary on a test machine, or the change does not affect it
  • New or changed texts are in every language under internal/i18n/locales (none)

The language, asked before an installation is looked for, stays at the left once answered, in the install and the upgrade, and Esc on the release notes asks it again.
@blaipr
blaipr merged commit 88654ec into main Oct 19, 2026
4 checks passed
@blaipr
blaipr deleted the fix/language-step-stays branch October 19, 2026 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant