Skip to content

chore(ci): spec-judge verdict gate (EA spec-0052) - #31

Merged
antonyevans merged 1 commit into
mainfrom
chore/spec-judge-gate-ci
Jun 12, 2026
Merged

antonyevans merged 1 commit into
mainfrom
chore/spec-judge-gate-ci

Conversation

@antonyevans

Copy link
Copy Markdown
Owner

New product specs (docs/spec-NNN-*.md) added alongside src/ changes must ship a judge verdict artifact (docs/judgments/.verdict.md with a PASS line). Backstops the EA-side product-spec judge gate for sessions/contributors not running under the EA harness. Spec-only PRs and no-spec PRs are unaffected. Origin: specs 138-143 were implemented unjudged on 2026-06-12; the retro-judge then found material design defects in 142/143.

🤖 Generated with Claude Code

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e735bae6e4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

if [ -z "$VERDICT" ]; then
echo "FAIL $SPEC: no verdict artifact docs/judgments/${ID}*.verdict.md (EA spec-0052: judge the spec before implementing it)"
FAIL=1
elif ! grep -qiE '^verdict: *(PASS|CONDITIONAL)' "$VERDICT"; then

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Require PASS verdicts in the gate

For PRs that add a spec with src/ changes, this accepts verdict: CONDITIONAL even though the newly added policy and script header say the artifact must contain a PASS verdict. A conditional judge result means the spec has not actually been iterated to PASS, so a contributor can satisfy CI with a non-passing verdict and still implement the spec, bypassing the gate this script is meant to enforce.

Useful? React with 👍 / 👎.

@antonyevans
antonyevans merged commit f250151 into main Jun 12, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant