Repository navigation
fix(notify): complete inbound coverage (escalation_response, object_revoke, profile_share) - #41
Merged
Merged
Conversation
Completes inbound notification coverage. Of the 12 envelope types, the inbound dispatcher (receiveEnvelope) applies 10; the notify policy table covered 7. The three remaining user-facing types arrived silently: - escalation_response: a friend's answer to a decision you raised (high signal) - object_revoke: a friend revoked access to something they shared - profile_share: a deliberate `profile broadcast` from a friend (a manual command, not auto housekeeping) Add policies for all three. Only protocol-level frames (ack/error) stay silent now. The single post_publish policy already covers every post sub-type (signal/query/answer/endorse/coordinate) since it keys on post_type. Tests: positive cases for the three new types; the two "silent type" tests now use ack (a genuine protocol frame) instead of profile_share. README updated to list complete coverage. Bumps to 0.18.5.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Completes inbound notification coverage so no user-facing inbound type arrives silently.
Review: coverage matrix
Edge Book has 12 envelope types. The inbound dispatcher (
receiveEnvelope) applies 10 of them (the other two,ack/error, are protocol-level and never dispatched). Before this PR the notify policy table covered 7:profile broadcast(manual command, not auto housekeeping)Posts (the
post_publishsub-taxonomy)No per-post-type work needed: a single
post_publishpolicy already covers every post sub-type —signal,query,answer,endorse,coordinate,share,delegation_request,capability_advertisement,result_attestation— because it keys onpost.post_typegenerically. A friend's broadcast feed post is delivered as apost_publishenvelope, so it's covered by the same watcher as a direct message (push model; the local feed = the store of receivedpost_publishitems).Tests
notificationIntentcases forescalation_response,object_revoke,profile_share.ack(a genuine protocol frame) instead ofprofile_share.npm test→ 511 pass; typecheck/lint/sync-readme clean.Note
profile_sharealso rides along the friend handshake (each side exchanges a profile), so friending now emits an "accepted" notification followed by a "shared a profile" one. It can be suppressed per-agent via thenotify_typeswhitelist if that's too chatty. README updated to list the complete coverage. Bumps to0.18.5.🤖 Generated with Claude Code