Skip to content

chore: add agents guidance files - #81

Merged
weited merged 1 commit into
mainfrom
chore/add-agents-guidance
Oct 1, 2026
Merged

weited merged 1 commit into
mainfrom
chore/add-agents-guidance

Conversation

@weited

@weited weited commented Oct 1, 2026

Copy link
Copy Markdown
Collaborator

Add agents guidance files

Copilot AI balanced review requested due to automatic review settings October 1, 2026 04:11

@grojeda grojeda left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The guidance includes an inaccurate testing requirement and a misleading ignore-rule heading.

Review effort: Balanced
Findings: 1 Low severity

Open (1)
What changed in this PR

Adds repository guidance for AI coding agents and exposes it to Claude-compatible tooling.

Changes:

  • Adds architecture, workflow, testing, and operational guidance.
  • Adds a CLAUDE.md reference to AGENTS.md.
  • Updates ignore rules to track the guidance files.
File Description
AGENTS.md Adds repository-wide agent guidance.
CLAUDE.md References the shared guidance file.
.gitignore Allows CLAUDE.md to be tracked.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread AGENTS.md

1. Upstream first: add the scanner rule in [aodn/data-services/ARGO/oceancurrent/oceancurrent_file_server_api.py](https://github.com/aodn/data-services/blob/master/ARGO/oceancurrent/oceancurrent_file_server_api.py), merge it to `master`, and wait for a cron run. Confirm the JSON is reachable under `REMOTE_BASE_URL` plus `REMOTE_RESOURCE_PATH`.
2. Here: add the group or leaf to `products.yaml`, setting `regionRequired`/`depthRequired` where needed. Add the JSON path(s) to `json-paths-config.yaml`.
3. Tests: extend `ProductConfigIntegrationTest`, `JsonPathsConfigTest` and `ProductServiceTest`.
@weited
weited merged commit c1a445d into main Oct 1, 2026
2 checks passed
@weited
weited deleted the chore/add-agents-guidance branch October 1, 2026 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants