build: refresh dependencies and release v0.4.0 - #122
Merged
Conversation
Update the cooldown-eligible runtime and Python dependencies, document the bundled CUDA license, and promote the canonical release version. Refs: #121 Co-authored-by: Codex <noreply@openai.com>
Move to CUDA 13.3.1, PyTorch 2.13, and ONNX 1.22 so the release uses compatible versions containing the available advisory fixes. Refs: #121 Co-authored-by: Codex <noreply@openai.com>
Retain the CUDA 12.9.1 runtime base required by the ONNX Runtime GPU wheel while PyTorch and xformers use their bundled CUDA 13.0 wheel libraries. Document the full GPU validation path that covers the previous WD14 startup regression. Refs: #121 Co-authored-by: Codex <noreply@openai.com>
Use a minor release because the PyTorch and xformers wheel stack moves from CUDA 12.9 to CUDA 13.0 and can change the supported GPU runtime behavior. Refs: #121 Co-authored-by: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
This pull request was created with assistance from LLMs.
Summary
charset-normalizerto 3.5.0 and the Ubuntu CA certificate package to20260601~24.04.1.VERSIONand the canonical changelog to v0.4.0.Related Issues
Notes for reviewers
The bundled sd-scripts checkout remains v0.11.1 on Python 3.10. Python 3.10 is intentional: the Python 3.12 attempt in #104 broke the accelerate/timm startup path and was reverted in #109. GitHub Actions, uv, Python, CUDA, hadolint, and APM were audited and already use their latest reviewed versions that completed the seven-day cooldown. No cooldown exception was used.
The initial CUDA 13.3 runtime candidate allowed PyTorch and xformers GPU execution but caused ONNX Runtime to fall back to CPU because its released Python 3.10 GPU wheel requires CUDA 12 libraries. The final image therefore keeps the CUDA 12.9.1 base and uses the independently bundled CUDA 13.0 PyTorch wheel stack. Both sides of that mixed runtime were exercised on an NVIDIA GeForce RTX 5070 Ti with driver 610.88 and compute capability 12.0. The release uses a minor-version bump because the PyTorch/xformers CUDA wheel line changes from CUDA 12.9 to CUDA 13.0.
Proposed merge attribution
Co-authored-by: Codex <noreply@openai.com>for material implementation assistance.AI disclosure
Codex inspected dependency and release metadata, prepared the source and lockfile updates, reviewed the final diff and container contents, investigated the #104/#109 regression history, and ran the reported CPU and GPU checks. The exact changes and outputs were reviewed before publication.
Testing
Automated checks
uv lock --checkapm audit --ci— all 10 repository-local checks passed.hadolint Dockerfileactionlintshellcheck scripts/*.shpinact run --check --min-age 7docker buildx build --check .docker build --progress=plain -t sd-scripts:v0.4.0-test .scripts/run-sd-scripts-release-tests.sh --image sd-scripts:v0.4.0-test— 142 passed, 7 skipped.GPU checks
memory_efficient_attentioncompleted with finite GPU output.Linear8bitLtcompleted with finite GPU output.CUDAExecutionProviderfirst, ran a generated ONNX model, and returned the expected result without CPU fallback.libonnxruntime_providers_cuda.sohad no unresolved dynamic-library dependencies with the GPU runtime mounted.accelerate launch finetune/tag_images_by_wd14_tagger.py --onnxdownloaded the real WD14 model, processed an actual image withCUDAExecutionProvider, and wrote the expected caption file. This exercises the startup path that failed after build: upgrade to Python 3.12 #104 and was restored by fix: restore Python 3.10 runtime #109.The optional upstream inpainting training scripts were not run because no compatible model checkpoint was supplied; they require a separate SD 1.5 or SDXL checkpoint. The dependency-specific GPU kernels and the complete WD14 model inference path were exercised instead.
The local Markdown CLI was unavailable; the pull-request
Checkjob runs the repository's pinned Markdown action.AI-assisted inspections