Skip to content

GH-46914: [C++][FlightSQL] Remove boost/algorithm/string.h dependency#50241

Merged
lidavidm merged 1 commit into
apache:mainfrom
Reranko05:gh-46914-remove-boost-string
Jun 23, 2026
Merged

GH-46914: [C++][FlightSQL] Remove boost/algorithm/string.h dependency#50241
lidavidm merged 1 commit into
apache:mainfrom
Reranko05:gh-46914-remove-boost-string

Conversation

@Reranko05

Copy link
Copy Markdown
Contributor

Rationale for this change

Issue #46914 requests removing the remaining boost/algorithm/string.hpp dependency from FlightSQL.

What changes are included in this PR?

  • Replace boost::iequals() with arrow::internal::AsciiEqualsCaseInsensitive()
  • Replace boost::istarts_with() with a local case-insensitive prefix helper
  • Remove boost/algorithm/string.hpp includes from sqlite_server.cc and test_app_cli.cc

Are these changes tested?

The modified files compile successfully in the local build configuration. CI will validate FlightSQL configurations.

Are there any user-facing changes?

No.

@Reranko05 Reranko05 requested a review from lidavidm as a code owner June 23, 2026 16:31
Copilot AI review requested due to automatic review settings June 23, 2026 16:31

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions github-actions Bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Jun 23, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

cpp/src/arrow/flight/sql/example/sqlite_server.cc:24

  • sqlite_server.cc uses std::strlen (see GetArrowType) but no longer includes <cstring> after removing the Boost header. Relying on transitive includes can break compilation on some platforms/toolchains; please include <cstring> explicitly.
#include <mutex>
#include <random>
#include <sstream>
#include <unordered_map>
#include <utility>

@lidavidm lidavidm merged commit 11721e7 into apache:main Jun 23, 2026
55 of 57 checks passed
@lidavidm lidavidm removed the awaiting merge Awaiting merge label Jun 23, 2026
@conbench-apache-arrow

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 11721e7.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 35 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants