Skip to content

_elementsources: cache intermediate combined sources (in-memory) #2094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
abderrahim wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −0
Draft

_elementsources: cache intermediate combined sources (in-memory) #2094

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/buildstream/_elementsources.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,8 @@ def __init__(self, context: Context, project: "Project", plugin: Plugin):
self._cache_key = None # Our cached cache key
self._proto = None # The cached Source proto

self._cache = {}

# get_project():
#
# Return the project associated with this object
Expand Down Expand Up @@ -462,6 +464,10 @@ def _stage(self, *, stop=None):
if source == stop:
break

if source in self._cache:
vdir = CasBasedDirectory(cas, digest=self._cache[source])
Comment on lines +467 to +468

@nathanwilliams-ct nathanwilliams-ct Aug 24, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if source in self._cache:
vdir = CasBasedDirectory(cas, digest=self._cache[source])
if (digest := self._cache.get(source)) is not None:
vdir = CasBasedDirectory(cas, digest)

continue

if source._directory:
vsubdir = vdir.open_directory(source._directory.lstrip(os.path.sep), create=True)
else:
Expand All @@ -483,6 +489,8 @@ def _stage(self, *, stop=None):
source_dir = self._sourcecache.export(source)
vsubdir.import_files(source_dir, collect_result=False)

self._cache[source] = vsubdir._get_digest()

return vdir

# Context manager that stages sources in a cas based or temporary file
Expand Down
Loading