[CALCITE-7696] Simplify window PARTITION BY and ORDER BY keys in RelBuilder - #5165
Open
xuzifu666 wants to merge 2 commits into
Open
[CALCITE-7696] Simplify window PARTITION BY and ORDER BY keys in RelBuilder#5165xuzifu666 wants to merge 2 commits into
xuzifu666 wants to merge 2 commits into
Conversation
mihaibudiu
reviewed
Aug 10, 2026
| * references fixed columns and is dropped, leaving {@code ORDER BY z}. */ | ||
| private ImmutableList<RexFieldCollation> simplifySortKeys( | ||
| List<RexNode> partitionKeys, List<RexFieldCollation> sortKeys) { | ||
| // A RANGE frame with a value offset (e.g. RANGE BETWEEN 5 PRECEDING) |
Contributor
There was a problem hiding this comment.
which test covers this case?
Member
Author
There was a problem hiding this comment.
Thank you for pointing out, I had added a test testProjectOverRangeOffsetKeepsSortKey to cover it. The new test would fail without the following modification.
|
mihaibudiu
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jira: https://issues.apache.org/jira/browse/CALCITE-7697