CASSANALYTICS-104: Eliminate redundant filesystem lookups in SSTable streaming - #239
Open
lukasz-antoniak wants to merge 1 commit into
Open
CASSANALYTICS-104: Eliminate redundant filesystem lookups in SSTable streaming#239lukasz-antoniak wants to merge 1 commit into
lukasz-antoniak wants to merge 1 commit into
Conversation
lukasz-antoniak
force-pushed
the
CASSANALYTICS-104
branch
2 times, most recently
from
August 31, 2026 12:16
3b0267c to
d49c9b5
Compare
lukasz-antoniak
force-pushed
the
CASSANALYTICS-104
branch
from
August 31, 2026 14:18
c3d5f0f to
93f4906
Compare
lukasz-antoniak
marked this pull request as ready for review
September 1, 2026 05:51
yifan-c
reviewed
Sep 1, 2026
yifan-c
left a comment
yifan-c
left a comment
Contributor
There was a problem hiding this comment.
Please update the CHANGES.txt
| .map(StackTraceElement::toString) | ||
| .collect(Collectors.joining("\n")); | ||
| String errorMessage = exception.getClass().getName() + ": " + exception.getMessage() | ||
| + "\n" + String.join("\n", stackTrace); |
Contributor
There was a problem hiding this comment.
String.join("\n", stackTrace) is equivalent to just stackTrace, right?
The stacktrace are already aggregated in the statement above.
| // 4. remove the sstables once sent | ||
| Map<Path, Digest> fileDigests = sstableWriter.prepareSStablesToSend(writerContext, sstables); | ||
| SortedSSTableWriter.PreparedSSTables preparedSSTables = sstableWriter.prepareSStablesToSend(writerContext, sstables); | ||
| // retain only the SSTable data components |
Contributor
There was a problem hiding this comment.
Please remove this comment, it is stale with the removal of .filter
| { | ||
| for (Path dataFile : dataFileStream) | ||
| { | ||
| if (isFileStreamed(dataFile)) |
Contributor
There was a problem hiding this comment.
StreamSession.isFileStreamed is now dead. Can you remove the code in the base class?
| LOGGER.info("[{}]: Uploading {} to {}: size={} digest={}", | ||
| sessionID, componentFile, instance.nodeName(), Files.size(componentFile), digest); | ||
| directDataTransferApi.uploadSSTableComponent(componentFile, ssTableIdx, instance, this.sessionID, digest); | ||
| recordStreamedFile(componentFile); |
Contributor
There was a problem hiding this comment.
The effect of this method has no use. It can be deleted, along with isFileStreamed
| { | ||
| for (Path componentFile : componentFileStream) | ||
| // send data component the last | ||
| if (preparedSSTable.dataFile().equals(componentFile)) |
Contributor
There was a problem hiding this comment.
Can dataFile() return null?
| */ | ||
| public static class PreparedSSTables | ||
| { | ||
| private static final PreparedSSTables EMPTY = new PreparedSSTables(); |
Contributor
There was a problem hiding this comment.
EMPTY is mutable. Caller can call addIfAbsent on it and mess up the state.
Comment on lines
+455
to
+458
| public PreparedSSTable addIfAbsent(Path path) | ||
| { | ||
| String baseName = SSTables.getSSTableDescriptor(path).baseFilename; | ||
| return sstables.computeIfAbsent(baseName, (__) -> new PreparedSSTable()); |
Contributor
There was a problem hiding this comment.
Based on the impl, getOrPrepareSSTable method name fits better.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes CASSANALYTICS-104.