CASSANDRA-21596: Remove the unused timeout pre-condition from the docker build scripts - #5052
Closed
aviau wants to merge 1 commit into
Closed
CASSANDRA-21596: Remove the unused timeout pre-condition from the docker build scripts#5052aviau wants to merge 1 commit into
aviau wants to merge 1 commit into
Conversation
Neither script ever invokes timeout(1). The container deadline is enforced by
docker itself, `docker run ... sleep ${docker_timeout_hours}h`, and
.build/run-tests.sh's _timeout_for only greps an ant property out of build.xml
to pass as -Dtest.timeout. macOS ships no timeout(1), so both scripts exit 1
on a stock macOS checkout over a tool they never use. The neighbouring docker
and bc checks stay, as those tools are genuinely invoked.
patch by Alexandre Viau; reviewed by TBD for CASSANDRA-21596
aviau
changed the title
michaelsembwever
approved these changes
Aug 22, 2026
Member
|
committed with cf64b6f |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.build/dockerscripts refuse to run without timeout, which they never invoke.patch by Alexandre Viau; reviewed by TBD for CASSANDRA-21596