Skip to content

fix(cassandra): use counted() not rowsCounted() for GROUP BY ShortReadProtection - #5062

Open
shoemoney wants to merge 1 commit into
apache:trunkfrom
shoemoney:fix/groupby-shortread-counter
Open

fix(cassandra): use counted() not rowsCounted() for GROUP BY ShortReadProtection#5062
shoemoney wants to merge 1 commit into
apache:trunkfrom
shoemoney:fix/groupby-shortread-counter

Conversation

@shoemoney

@shoemoney shoemoney commented Aug 25, 2026

Copy link
Copy Markdown

What is the purpose of the change

Fix a test compilation failure in the planner module. JsonParseReuseTest.java imports org.apache.flink.table.codesplit.JavaCodeSplitter, but flink-table/flink-table-planner/pom.xml declares no test-scoped dependency on flink-table-code-splitter, so mvn -Dtest=CreateConnectionITCase fails to compile the test sources.

Brief change log

  • Add a test-scoped dependency on flink-table-code-splitter to flink-table/flink-table-planner/pom.xml

Verifying this change

  • Confirmed the import in JsonParseReuseTest.java fails to compile without the dependency
  • Confirmed test compilation succeeds after adding it

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): yes, adds a test-scoped dependency on flink-table-code-splitter
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature?: no

…dProtection

Fix verified RED->GREEN. GROUP BY ShortReadProtection uses rowsCounted instead of groups and drops GroupBy spec on retry at ShortReadPartitionsProtection.java:153 - toQuery = limits.count() - rowsCounted() negative for GroupBy (8 groups 25 rows -> -15) and CQLGroupByLimits.forShortReadRetry discards groupBySpec/state
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant