Override option for default consistency levels in cqlsh - #5066
Open
michaelsembwever wants to merge 1 commit into
Open
Override option for default consistency levels in cqlsh#5066michaelsembwever wants to merge 1 commit into
michaelsembwever wants to merge 1 commit into
Conversation
Add the --consistency-level and --serial-consistency-level options, and the matching consistency_level and serial_consistency_level settings in the [cql] section of cqlshrc. The defaults stay ONE and SERIAL. cqlsh fails to start when either value is invalid. Upstreamed from datastax/cassandra commit 87929f1 patch by Michael Semb Wever; reviewed by TBD for CASSANDRA-20626 Assisted-by: Claude Code:claude-opus-5
driftx
requested changes
Aug 26, 2026
| self.page_size = self.default_page_size | ||
| self.expand_enabled = expand_enabled | ||
|
|
||
| if not consistency_level: |
Contributor
There was a problem hiding this comment.
Need to compare to None to make the exception correct, and also this will catch ConsistencyLevel.ANY which is numerically zero.
| if not consistency_level: | ||
| raise Exception('Argument consistency_level must not be None') | ||
| if not serial_consistency_level: | ||
| raise Exception('Argument serial_consistency_level must not be None') |
Contributor
There was a problem hiding this comment.
Misleading exception here too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the --consistency-level and --serial-consistency-level options, and the matching consistency_level and serial_consistency_level settings in the [cql] section of cqlshrc. The defaults stay ONE and SERIAL. cqlsh fails to start when either value is invalid.
Upstreamed from datastax/cassandra commit 87929f1