[CASSANDRA-21175][trunk] Upgrade Netty to 4.2.17.Final and netty-tcnative to 2.0.81.Final - #5076
Open
netudima wants to merge 1 commit into
Open
[CASSANDRA-21175][trunk] Upgrade Netty to 4.2.17.Final and netty-tcnative to 2.0.81.Final#5076netudima wants to merge 1 commit into
netudima wants to merge 1 commit into
Conversation
Netty 4.2 replaced the allocation hook of UnpooledDirectByteBuf: capacity(int) now calls allocateDirectBuffer(int), returning a CleanableDirectBuffer, and the deprecated allocateDirect(int)/freeDirect(ByteBuffer) are no longer consulted on that path. BufferPoolAllocator.Wrapped is updated to override the new hook, otherwise a resized buffer is allocated outside of Cassandra's BufferPool and fails to be returned to it on release. Excludes the modules netty-all newly aggregates in 4.2 that Cassandra does not use: http3, quic, marshalling, protobuf and io_uring (it is not in use so far). patch by Dmitry Konstantinov; reviewed by TBD for CASSANDRA-21175
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Netty 4.2 replaced the allocation hook of UnpooledDirectByteBuf: capacity(int) now calls allocateDirectBuffer(int), returning a CleanableDirectBuffer, and the deprecated allocateDirect(int)/freeDirect(ByteBuffer) are no longer consulted on that path. BufferPoolAllocator.Wrapped is updated to override the new hook, otherwise a resized buffer is allocated outside of Cassandra's BufferPool and fails to be returned to it on release.
Excludes the modules netty-all newly aggregates in 4.2 that Cassandra does not use: http3, quic, marshalling, protobuf and io_uring (it is not in use so far).
patch by Dmitry Konstantinov; reviewed by TBD for CASSANDRA-21175