Allow nodetool cms reconfigure to ignore specific hosts - #5085
Open
nvharikrishna wants to merge 1 commit into
Open
Allow nodetool cms reconfigure to ignore specific hosts#5085nvharikrishna wants to merge 1 commit into
nvharikrishna wants to merge 1 commit into
Conversation
Add a --ignore option to nodetool cms reconfigure. Hosts given to it are excluded from the new CMS, on top of any nodes that are already down. This helps when shrinking a cluster. Today, decommissioning a CMS member hands that role to another node which may itself be due for decommission, so the CMS has to be reconfigured again and again. Excluding the departing nodes up front keeps CMS membership stable for the whole shrink, because decommissioning a node that is not a CMS member does not trigger a reconfiguration. The ignore list applies to that one command only. It is not stored, so cms describe still reports whether the CMS matches the nodes currently in the cluster. patch by nvharikrishna; reviewed by <Reviewers> for CASSANDRA-21627
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Same as #5084 , but for cassandra-6.0 branch)
Add a
--ignoreoption tonodetool cms reconfigure. Hosts given to it are excluded from the new CMS, on top of any nodes that are already down.This helps when shrinking a cluster. Today, decommissioning a CMS member hands that role to another node which may itself be due for decommission, so the CMS has to be reconfigured again and again. Excluding the departing nodes up front keeps CMS membership stable for the whole shrink, because decommissioning a node that is not a CMS member does not trigger a reconfiguration.
The ignore list applies to that one command only. It is not stored, so cms describe still reports whether the CMS matches the nodes currently in the cluster.
patch by nvharikrishna; reviewed by for CASSANDRA-21627
CASSANDRA-21627