Skip to content

marvin: use pycryptodome instead of PyCrypt#13594

Open
weizhouapache wants to merge 1 commit into
apache:mainfrom
weizhouapache:4.23-marvin-pycryptodome
Open

marvin: use pycryptodome instead of PyCrypt#13594
weizhouapache wants to merge 1 commit into
apache:mainfrom
weizhouapache:4.23-marvin-pycryptodome

Conversation

@weizhouapache

Copy link
Copy Markdown
Member

Description

This PR...

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Copilot AI review requested due to automatic review settings July 11, 2026 13:16
@boring-cyborg boring-cyborg Bot added component:marvin Python Warning... Python code Ahead! labels Jul 11, 2026
@weizhouapache

Copy link
Copy Markdown
Member Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Marvin’s Python packaging metadata to depend on pycryptodome instead of PyCrypt, aligning the Marvin install requirements with the Crypto.* module usage found in the integration test suite.

Changes:

  • Replace PyCrypt with pycryptodome in tools/marvin/setup.py install_requires.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov

codecov Bot commented Jul 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 19.47%. Comparing base (a503a52) to head (20587bf).

Additional details and impacted files
@@            Coverage Diff            @@
##               main   #13594   +/-   ##
=========================================
  Coverage     19.47%   19.47%           
  Complexity    19351    19351           
=========================================
  Files          6296     6296           
  Lines        568368   568368           
  Branches      69622    69622           
=========================================
+ Hits         110673   110702   +29     
+ Misses       445618   445586   -32     
- Partials      12077    12080    +3     
Flag Coverage Δ
uitests 3.44% <ø> (ø)
unittests 20.73% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18541

@weizhouapache

Copy link
Copy Markdown
Member Author

@blueorangutan test matrix

@blueorangutan

Copy link
Copy Markdown

@weizhouapache a [SL] Trillian-Jenkins matrix job (EL8 mgmt + EL8 KVM, Ubuntu22 mgmt + Ubuntu22 KVM, EL8 mgmt + VMware 7.0u3, EL9 mgmt + XCP-ng 8.2 ) has been kicked to run smoke tests

@blueorangutan

Copy link
Copy Markdown

[SF] Trillian Build Failed (tid-16532)

@blueorangutan

Copy link
Copy Markdown

[SF] Trillian Build Failed (tid-16534)

@blueorangutan

Copy link
Copy Markdown

[SF] Trillian Build Failed (tid-16531)

@blueorangutan

Copy link
Copy Markdown

[SF] Trillian Build Failed (tid-16535)

@blueorangutan

Copy link
Copy Markdown

[SF] Trillian test result (tid-16537)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 54246 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13594-t16537-kvm-ol8.zip
Smoke tests completed. 154 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:marvin Python Warning... Python code Ahead!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants