Skip to content

Rename draft-THREAT-MODEL.md to THREAT_MODEL.md (canonical discoverability name)#13599

Merged
vishesh92 merged 1 commit into
apache:mainfrom
potiuk:asf-security/rename-threat-model-canonical
Jul 13, 2026
Merged

Rename draft-THREAT-MODEL.md to THREAT_MODEL.md (canonical discoverability name)#13599
vishesh92 merged 1 commit into
apache:mainfrom
potiuk:asf-security/rename-threat-model-canonical

Conversation

@potiuk

@potiuk potiuk commented Jul 13, 2026

Copy link
Copy Markdown
Member

The project-wide security threat model merged in #13293 as draft-THREAT-MODEL.md. The canonical filename that security scanners and the satellite repos' SECURITY.md pointers follow is THREAT_MODEL.md.

This PR renames the file to THREAT_MODEL.md and updates the in-repo SECURITY.md reference to match. It makes the pointer already merged into apache/cloudstack-cloudmonkey (which targets .../blob/main/THREAT_MODEL.md) resolve, fixing broken automated-discovery links flagged on apache/cloudstack-cloudmonkey#212.

The document's own review-status wording (still "under maintainer review") is unchanged — this is purely a filename/pointer fix for discoverability.

The project-wide security threat model merged (apache#13293)
as draft-THREAT-MODEL.md, but the canonical discoverability name that
scanners and satellite-repo SECURITY.md pointers follow is THREAT_MODEL.md.

This renames the file to THREAT_MODEL.md and updates the in-repo
SECURITY.md reference, making the pointer in apache/cloudstack-cloudmonkey
(which already targets .../blob/main/THREAT_MODEL.md) resolve. The
document's own review-status wording is unchanged.

Generated-by: Claude Opus 4.8 (1M context)
Copilot AI review requested due to automatic review settings July 13, 2026 10:24

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR standardizes threat-model discoverability by moving the project’s canonical threat model document to the expected filename (THREAT_MODEL.md) and updating the in-repo SECURITY.md pointer accordingly, so automated tooling and satellite repositories can resolve the link reliably.

Changes:

  • Rename/add the canonical threat-model document as THREAT_MODEL.md.
  • Update SECURITY.md to link to THREAT_MODEL.md.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
THREAT_MODEL.md Introduces the threat model at the canonical filename used by security-scanner discovery chains.
SECURITY.md Updates the threat-model link to point at THREAT_MODEL.md.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov

codecov Bot commented Jul 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 19.50%. Comparing base (24fd90a) to head (3168971).

Additional details and impacted files
@@             Coverage Diff              @@
##              main   #13599       +/-   ##
============================================
+ Coverage     3.41%   19.50%   +16.08%     
- Complexity       0    19441    +19441     
============================================
  Files          486     6303     +5817     
  Lines        41774   569288   +527514     
  Branches      7899    69792    +61893     
============================================
+ Hits          1428   111037   +109609     
- Misses       40148   446097   +405949     
- Partials       198    12154    +11956     
Flag Coverage Δ
uitests 3.41% <ø> (ø)
unittests 20.77% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vishesh92 vishesh92 merged commit d2a3bd1 into apache:main Jul 13, 2026
17 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants