Fix importVM for use with dummy template - #14195
Conversation
…mportVM. findByID will fail for dummy template as it is stored in the deleted state.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.22 #14195 +/- ##
=========================================
Coverage 17.97% 17.98%
- Complexity 16184 16186 +2
=========================================
Files 5930 5930
Lines 535615 535614 -1
Branches 65582 65582
=========================================
+ Hits 96271 96304 +33
+ Misses 428377 428336 -41
- Partials 10967 10974 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
weizhouapache
left a comment
There was a problem hiding this comment.
code lgtm
need re-testing
rajujith
left a comment
There was a problem hiding this comment.
LGTM
Tested
ImportVm works fine without any error.
|
@blueorangutan package |
|
@abh1sar a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19279 |
|
@blueorangutan test |
|
@abh1sar a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
|
[SF] Trillian test result (tid-17022)
|
Description
This PR fixes the
Unable to find template with id 202 for virtual machine importerror thrown when importing a VM.The dummy template
VM Import Default Templateis stored in the removed state, so findById returns null and importVM fails.Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Tested ImportVmCmd with and without the fix
How did you try to break this feature and the system with this change?