(WIP)CKS: reconcile node capacity after live resize - #14223
andrijapanicsb wants to merge 6 commits into
Quality Gate failed
Failed conditions
28.9% Coverage on New Code (required ≥ 40%)
Annotations
sonarqubecloud / SonarCloud Code Analysis
This statement will not be executed conditionally; only the first statement will be. The rest will execute unconditionally.
See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaDJI_XoJBZ3696PvGsc&open=AaDJI_XoJBZ3696PvGsc&pullRequest=14223
sonarqubecloud / SonarCloud Code Analysis
Declare "unit" on a separate line.
See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaDJI_XoJBZ3696PvGse&open=AaDJI_XoJBZ3696PvGse&pullRequest=14223
sonarqubecloud / SonarCloud Code Analysis
Replace generic exceptions with specific library exceptions or a custom exception.
See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaDJI_XyJBZ3696PvGso&open=AaDJI_XyJBZ3696PvGso&pullRequest=14223
sonarqubecloud / SonarCloud Code Analysis
Declare "capacityCpuMillis" and all following declarations on a separate line.
See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaDJI_XyJBZ3696PvGss&open=AaDJI_XyJBZ3696PvGss&pullRequest=14223
sonarqubecloud / SonarCloud Code Analysis
Replace generic exceptions with specific library exceptions or a custom exception.
See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaDJI_XyJBZ3696PvGsm&open=AaDJI_XyJBZ3696PvGsm&pullRequest=14223
sonarqubecloud / SonarCloud Code Analysis
Replace generic exceptions with specific library exceptions or a custom exception.
See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaDJI_XyJBZ3696PvGsj&open=AaDJI_XyJBZ3696PvGsj&pullRequest=14223
sonarqubecloud / SonarCloud Code Analysis
Use concise character class syntax '\\d' instead of '[0-9]'.
See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaDJI_XoJBZ3696PvGsd&open=AaDJI_XoJBZ3696PvGsd&pullRequest=14223
sonarqubecloud / SonarCloud Code Analysis
Declare "cloudStackResizeCordon" and all following declarations on a separate line.
See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaDJI_XyJBZ3696PvGsr&open=AaDJI_XyJBZ3696PvGsr&pullRequest=14223
sonarqubecloud / SonarCloud Code Analysis
Declare "status" on a separate line.
See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaDJI_XoJBZ3696PvGsf&open=AaDJI_XoJBZ3696PvGsf&pullRequest=14223
sonarqubecloud / SonarCloud Code Analysis
Declare "memoryKiB" on a separate line.
See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaDJI_XoJBZ3696PvGsi&open=AaDJI_XoJBZ3696PvGsi&pullRequest=14223
sonarqubecloud / SonarCloud Code Analysis
Declare "controlPort" and all following declarations on a separate line.
See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaDJI_XyJBZ3696PvGsp&open=AaDJI_XyJBZ3696PvGsp&pullRequest=14223
sonarqubecloud / SonarCloud Code Analysis
Replace generic exceptions with specific library exceptions or a custom exception.
See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaDJI_XyJBZ3696PvGsl&open=AaDJI_XyJBZ3696PvGsl&pullRequest=14223
sonarqubecloud / SonarCloud Code Analysis
Declare "allocatableMemoryBytes" and all following declarations on a separate line.
See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaDJI_XyJBZ3696PvGst&open=AaDJI_XyJBZ3696PvGst&pullRequest=14223
sonarqubecloud / SonarCloud Code Analysis
Constructor has 9 parameters, which is greater than 7 authorized.
See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaDJI_XyJBZ3696PvGsu&open=AaDJI_XyJBZ3696PvGsu&pullRequest=14223
sonarqubecloud / SonarCloud Code Analysis
Refactor this method to reduce its Cognitive Complexity from 43 to the 15 allowed.
See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaDJI_DaJBZ3696PvGsb&open=AaDJI_DaJBZ3696PvGsb&pullRequest=14223
sonarqubecloud / SonarCloud Code Analysis
Remove this field injection and use constructor injection instead.
See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaDJI_DaJBZ3696PvGsa&open=AaDJI_DaJBZ3696PvGsa&pullRequest=14223
sonarqubecloud / SonarCloud Code Analysis
Declare "allocatable" on a separate line.
See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaDJI_XoJBZ3696PvGsg&open=AaDJI_XoJBZ3696PvGsg&pullRequest=14223
sonarqubecloud / SonarCloud Code Analysis
Declare "sshKeyFile" on a separate line.
See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaDJI_XyJBZ3696PvGsq&open=AaDJI_XyJBZ3696PvGsq&pullRequest=14223
sonarqubecloud / SonarCloud Code Analysis
Replace generic exceptions with specific library exceptions or a custom exception.
See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaDJI_XyJBZ3696PvGsk&open=AaDJI_XyJBZ3696PvGsk&pullRequest=14223
sonarqubecloud / SonarCloud Code Analysis
Declare "observedMemory" on a separate line.
See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaDJI_XoJBZ3696PvGsh&open=AaDJI_XoJBZ3696PvGsh&pullRequest=14223
sonarqubecloud / SonarCloud Code Analysis
Replace generic exceptions with specific library exceptions or a custom exception.
See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaDJI_XyJBZ3696PvGsn&open=AaDJI_XyJBZ3696PvGsn&pullRequest=14223