Skip to content

Fix get upload params NPE - #6079

Merged
nvazquez merged 1 commit into
apache:4.16from
shapeblue:fixuploadparamsnpe
Mar 10, 2022
Merged

nvazquez merged 1 commit into
apache:4.16from
shapeblue:fixuploadparamsnpe

Conversation

@nvazquez

@nvazquez nvazquez commented Mar 9, 2022

Copy link
Copy Markdown
Contributor

Description

This PR an NPE on getUploadTemplateParams for template upload
Fixes: #6071

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

(localcloud) 🐱 > get uploadparamsfortemplate name=test displaytext=test format=ova hypervisor=vmware ostypeid=6413d8a6-a06a-11ec-86fc-1e003900042d zoneid=17923b3f-5f1a-4098-8277-50adb4e7e909 
{
  "getuploadparams": {
    "expires": "2022-03-10T13:33:08.844Z",
    "id": "a7fc1eea-ad80-4105-8a79-8e628e2571d2",
    "metadata": "nEUT1wgt9S2Bh1B7wKLq1yVOSvGnQzF+Q2esSrTZ6Q6ZDXlFZfMkyviE/RfH16pUXHBhLubLVNUCydT+IGBudRJ0re5IEct4n0X3b0/v96rjyz0dLjjaXUGcNNRhs1ZC/vOs3CEfcAeSTyhC2Tq17XCiUWkK4jKOWk3+po0gfSTzEU1/9lIE/JHaXdaZbP5E2ykuoICO6/kb/3RjNfivBqg9rJP6U+KTsVJBbd09xVmD7og/5cqtZsSZt6b6C7Vgqgg+chaQcSsKbNyrHjxOMuNCTOlCqJH5QZg7q1TVvrsz22IW+RmgF/EkVaRNLcI8ioVWOcMwAhfo9RBgTADfvWNu1GeqEiixMYcfK2S3NxwVlzwKGq59uOv/PRqjTzOpHcN5v3ebfpLBQMW1D9lVWG/3iR4qho1appclU0q+EtgOJP64UFsFE4rKBfnsF5p0+dTXbeLwynwYgjdzOkSyRobBlkvbSeb48o+xymRemSjYAvMvX12dq2EL1URNRJe376F0Zi+T2sJ8u6rca7ZvZ12ZfKBAlz/mnj6gZoGxE8pAsRbFni6IwXW9ADyGkGRTv0E8K1l8zPuq0iItX4nBoawjN+zSJAt9m2g2JTyL1hn4HC3flOvIZLppuAkXDR5m4HgEoVG4934M1C/J04QlPAOSvcVlO9YWc07CSZHy5Zc=",
    "postURL": "https://10.0.55.142/upload/a7fc1eea-ad80-4105-8a79-8e628e2571d2",
    "signature": "nJFx/0nqIrfluslTgoXhhEyo0gA="
  }
}

@nvazquez

nvazquez commented Mar 9, 2022

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@weizhouapache weizhouapache left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@blueorangutan

Copy link
Copy Markdown

Packaging result: ✔️ el7 ✔️ el8 ✖️ debian ✖️ suse15. SL-JID 2815

@nvazquez

nvazquez commented Mar 9, 2022

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2818

@nvazquez

nvazquez commented Mar 9, 2022

Copy link
Copy Markdown
Contributor Author

@blueorangutan test

@blueorangutan

Copy link
Copy Markdown

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan

Copy link
Copy Markdown

Trillian test result (tid-3549)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 24687 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6079-t3549-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py

@nvazquez

Copy link
Copy Markdown
Contributor Author

@blueorangutan test

@blueorangutan

Copy link
Copy Markdown

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@DaanHoogland DaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@Pearl1594 Pearl1594 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLGTM

@blueorangutan

Copy link
Copy Markdown

Trillian test result (tid-3553)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31191 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6079-t3553-kvm-centos7.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:

Test Result Time (s) Test File

@nvazquez
nvazquez merged commit 067c1de into apache:4.16 Mar 10, 2022
yadvr pushed a commit to shapeblue/cloudstack that referenced this pull request May 18, 2022
(cherry picked from commit 067c1de)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
yadvr pushed a commit to shapeblue/cloudstack that referenced this pull request May 18, 2022
(cherry picked from commit 067c1de)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants