Skip to content

UI: Fix route to domain details - #6086

Merged
nvazquez merged 1 commit into
apache:mainfrom
shapeblue:domain-details-route-fix
Mar 10, 2022
Merged

nvazquez merged 1 commit into
apache:mainfrom
shapeblue:domain-details-route-fix

Conversation

@Pearl1594

Copy link
Copy Markdown
Contributor

Description

This PR fixes router link to domain details

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@Pearl1594

Copy link
Copy Markdown
Contributor Author

@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6086 (SL-JID-1237)

@shwstppr

Copy link
Copy Markdown
Contributor

@Pearl1594 don't think it is related but getting error on navigation,
nav-error

@Pearl1594

Copy link
Copy Markdown
Contributor Author

Yes @shwstppr that's something I've been investigating.. It's not related to this PR.. I noticed this on the QA server too..

@nvazquez

Copy link
Copy Markdown
Contributor

Hi @utchoang have any hint on what could be causing the navigation to back issue? It seems like when clicking the back button the wrong UUID is sent. Anyways this would need a separate issue

@nvazquez nvazquez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nvazquez
nvazquez merged commit 07d1ffc into apache:main Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants