Skip to content

ui: update npm dependencies to latest - #6091

Merged
yadvr merged 3 commits into
apache:mainfrom
shapeblue:npm-update-mar22
Mar 15, 2022
Merged

ui: update npm dependencies to latest#6091
yadvr merged 3 commits into
apache:mainfrom
shapeblue:npm-update-mar22

Conversation

@yadvr

@yadvr yadvr commented Mar 10, 2022

Copy link
Copy Markdown
Member

Run commands to update dependencies:

npm outdated
npm update

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

@yadvr
ui: update npm dependencies to latest
4f8c162 
Run commands to update dependencies:

    npm outdated
    npm update

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@yadvr

yadvr commented Mar 10, 2022

Copy link
Copy Markdown
Member Author

@blueorangutan ui

@blueorangutan

blueorangutan commented Mar 10, 2022

Copy link
Copy Markdown

@rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented Mar 10, 2022

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6091 (SL-JID-1240)

@yadvr

yadvr commented Mar 10, 2022

Copy link
Copy Markdown
Member Author

@blueorangutan package

@blueorangutan

blueorangutan commented Mar 10, 2022

Copy link
Copy Markdown

@rohityadavcloud a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented Mar 10, 2022

Copy link
Copy Markdown

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2835

@yadvr

yadvr commented Mar 13, 2022

Copy link
Copy Markdown
Member Author

@blueorangutan ui
@blueorangutan package

@blueorangutan

blueorangutan commented Mar 13, 2022

Copy link
Copy Markdown

@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented Mar 13, 2022

Copy link
Copy Markdown

@rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented Mar 13, 2022

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6091 (SL-JID-1250)

@blueorangutan

blueorangutan commented Mar 13, 2022

Copy link
Copy Markdown

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2857

utchoang
utchoang approved these changes Mar 14, 2022
View reviewed changes

@utchoang utchoang left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

davidjumani
davidjumani approved these changes Mar 14, 2022
View reviewed changes

@davidjumani davidjumani left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLGTM. Will run tests of this along with Vue3

@davidjumani davidjumani mentioned this pull request Mar 14, 2022
Closed
@yadvr

yadvr commented Mar 14, 2022

Copy link
Copy Markdown
Member Author

@davidjumani great, agree. Let's merge this only after running some manual tests.

@davidjumani davidjumani mentioned this pull request Mar 14, 2022
Closed
davidjumani
davidjumani approved these changes Mar 15, 2022
View reviewed changes

@davidjumani davidjumani left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran basic tests, Good to merge. Can continue testing once merged

@yadvr yadvr added this to the 4.17.0.0 milestone Mar 15, 2022
@yadvr
yadvr merged commit b296546 into apache:main Mar 15, 2022
@yadvr
yadvr deleted the npm-update-mar22 branch March 15, 2022 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidjumani davidjumani davidjumani approved these changes
@sureshanaparti sureshanaparti sureshanaparti approved these changes
@utchoang utchoang utchoang approved these changes
@nvazquez nvazquez Awaiting requested review from nvazquez

Assignees

No one assigned

Labels

component:UI type:enhancement

Projects

No open projects
Apache CloudStack 4.17.0
Status: Todo

Milestone

4.17.0.0

Development

Successfully merging this pull request may close these issues.

6 participants

@yadvr @blueorangutan @davidjumani @sureshanaparti @utchoang @nvazquez