Direct download certificates additions and improvements by nvazquez · Pull Request #6104 · apache/cloudstack

nvazquez · 2022-03-14T02:29:30Z

Description

This PR adds some improvements around the direct download functionality:

Add a new API for certificates listing
Add a new API to provision an uploaded certificate to a host
Refactor the revokeTemplateDirectDownloadCertificate API
Refactor the uploadTemplateDirectDownloadCertificate API

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

nvazquez · 2022-03-14T02:30:34Z

@blueorangutan package

blueorangutan · 2022-03-14T02:31:03Z

@nvazquez a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2022-03-14T02:33:11Z

Packaging result: ✖️ el7 ✖️ el8 ✖️ debian ✖️ suse15. SL-JID 2858

nvazquez · 2022-03-14T02:37:47Z

@blueorangutan package

blueorangutan · 2022-03-14T02:38:02Z

@nvazquez a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2022-03-14T03:21:17Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2859

nvazquez · 2022-03-14T10:44:35Z

@blueorangutan package

blueorangutan · 2022-03-14T10:45:03Z

@nvazquez a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2022-03-14T11:21:14Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2864

Co-authored-by: Suresh Kumar Anaparti <sureshkumar.anaparti@gmail.com>

nvazquez · 2022-03-14T11:43:23Z

@blueorangutan package

blueorangutan · 2022-03-14T11:44:03Z

@nvazquez a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2022-03-14T11:47:26Z

Packaging result: ✖️ el7 ✖️ el8 ✖️ debian ✖️ suse15. SL-JID 2865

nvazquez · 2022-03-14T12:49:52Z

@blueorangutan package

blueorangutan · 2022-03-14T12:51:03Z

@nvazquez a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2022-03-14T13:31:19Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2867

nvazquez · 2022-03-15T17:08:13Z

@blueorangutan package

nvazquez · 2022-04-06T02:26:14Z

Thanks @weizhouapache - fixing the APINAME has fixed the issue of the ID on cmk, have fixed your comments and retested
@blueorangutan package

blueorangutan · 2022-04-06T02:27:03Z

@nvazquez a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2022-04-06T03:05:23Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3083

nvazquez · 2022-04-06T03:05:59Z

@blueorangutan test

blueorangutan · 2022-04-06T03:07:02Z

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2022-04-06T12:15:44Z

Trillian test result (tid-3827)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31603 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6104-t3827-kvm-centos7.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File

weizhouapache · 2022-04-11T09:09:24Z

tested OK with following apis.

upload templatedirectdownloadcertificate
list templatedirectdownloadcertificates
list templatedirectdownloadcertificates listhosts=true
provision templatedirectdownloadcertificate
revoke templatedirectdownloadcertificate

verified keystore OK by keytool

small suggestion:
would be good to add id of the certificate to the response of upload templatedirectdownloadcertificate ?
now the response looks like

{
  "count": 3,
  "directdownloadcertificatehoststatus": [
    {
      "details": "",
      "hostid": "6435a58b-86e0-43d5-81b0-25c0a73dce0d",
      "hostname": "kvm1",
      "status": "UPLOADED"
    },
    {
      "details": "",
      "hostid": "41bd94dc-4903-4891-bbe4-f093097f844a",
      "hostname": "kvm2",
      "status": "UPLOADED"
    },
    {
      "details": "",
      "hostid": "a6ca44ed-394f-4607-925f-99d825be7839",
      "hostname": "kvm3",
      "status": "UPLOADED"
    }
  ]
}

nvazquez · 2022-04-11T11:08:24Z

@blueorangutan package

blueorangutan · 2022-04-11T11:09:03Z

@nvazquez a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2022-04-11T11:54:35Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3116

nvazquez · 2022-04-11T11:57:27Z

@blueorangutan package

blueorangutan · 2022-04-11T11:58:03Z

@nvazquez a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2022-04-11T12:34:22Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3117

nvazquez · 2022-04-11T12:35:08Z

@blueorangutan test

blueorangutan · 2022-04-11T12:38:03Z

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2022-04-11T22:12:05Z

Trillian test result (tid-3852)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33004 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6104-t3852-kvm-centos7.zip
Smoke tests completed. 93 look OK, 0 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File

…ache#6104) (#140) * Direct download certificates additions and improvements (apache#6104) * Add direct download certificates listing * Restore class to original project * Small refactor * Register API * Apply suggestions from code review Co-authored-by: Suresh Kumar Anaparti <sureshkumar.anaparti@gmail.com> * Refactor after review * Fix checkstyle * Add hosts mapping to API response * Improvements on revoke certificate * Refactor revoke certificate API * Fix condition * Filter only certificates not revoked for revokeCertificate API * Improve upload certificate and add provision certificate API * Improve certificate response output * Address review comments * Refactor revoke cert test * Fix marvin test * Address review comments * Fix issues * Improvements * Refactor upload template API response * Fix response Co-authored-by: Suresh Kumar Anaparti <sureshkumar.anaparti@gmail.com> * Fix pom version Co-authored-by: Suresh Kumar Anaparti <sureshkumar.anaparti@gmail.com>

nvazquez · 2022-10-31T19:13:33Z

@blueorangutan package

blueorangutan · 2022-10-31T19:14:03Z

@nvazquez a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Add direct download certificates listing

7d6fc63

nvazquez added the type:enhancement label Mar 14, 2022

nvazquez added this to the 4.17.0.0 milestone Mar 14, 2022

Restore class to original project

f29fc4d

Small refactor

0daae73

Register API

2c1b781

sureshanaparti reviewed Mar 14, 2022

View reviewed changes

Comment thread ...he/cloudstack/api/command/admin/direct/download/ListTemplateDirectDownloadCertificasCmd.java Outdated

sureshanaparti reviewed Mar 14, 2022

View reviewed changes

Comment thread ...he/cloudstack/api/command/admin/direct/download/ListTemplateDirectDownloadCertificasCmd.java Outdated

sureshanaparti reviewed Mar 14, 2022

View reviewed changes

Comment thread api/src/main/java/org/apache/cloudstack/api/response/DirectDownloadCertificateResponse.java Outdated

nvazquez and others added 2 commits March 14, 2022 08:38

Apply suggestions from code review

2904a0e

Co-authored-by: Suresh Kumar Anaparti <sureshkumar.anaparti@gmail.com>

Refactor after review

978fa68

Fix checkstyle

e969c2d

nvazquez added 2 commits March 15, 2022 11:27

Add hosts mapping to API response

596ef37

Improvements on revoke certificate

7401183

weizhouapache approved these changes Apr 11, 2022

View reviewed changes

Refactor upload template API response

fa872be

boring-cyborg Bot added component:api component:build component:integration-test component:management-server Python Warning... Python code Ahead! labels Apr 11, 2022

Fix response

eb9458d

nvazquez merged commit 5435b0a into apache:main Apr 12, 2022

apache deleted a comment from blueorangutan Oct 31, 2022

Conversation

nvazquez commented Mar 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

nvazquez commented Mar 14, 2022

Uh oh!

blueorangutan commented Mar 14, 2022

Uh oh!

blueorangutan commented Mar 14, 2022

Uh oh!

nvazquez commented Mar 14, 2022

Uh oh!

blueorangutan commented Mar 14, 2022

Uh oh!

blueorangutan commented Mar 14, 2022

Uh oh!

nvazquez commented Mar 14, 2022

Uh oh!

blueorangutan commented Mar 14, 2022

Uh oh!

blueorangutan commented Mar 14, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nvazquez commented Mar 14, 2022

Uh oh!

blueorangutan commented Mar 14, 2022

Uh oh!

blueorangutan commented Mar 14, 2022

Uh oh!

nvazquez commented Mar 14, 2022

Uh oh!

blueorangutan commented Mar 14, 2022

Uh oh!

blueorangutan commented Mar 14, 2022

Uh oh!

nvazquez commented Mar 15, 2022

Uh oh!

nvazquez commented Apr 6, 2022

Uh oh!

blueorangutan commented Apr 6, 2022

Uh oh!

blueorangutan commented Apr 6, 2022

Uh oh!

nvazquez commented Apr 6, 2022

Uh oh!

blueorangutan commented Apr 6, 2022

Uh oh!

blueorangutan commented Apr 6, 2022

Uh oh!

weizhouapache commented Apr 11, 2022

Uh oh!

nvazquez commented Apr 11, 2022

Uh oh!

blueorangutan commented Apr 11, 2022

Uh oh!

blueorangutan commented Apr 11, 2022

Uh oh!

nvazquez commented Apr 11, 2022

Uh oh!

blueorangutan commented Apr 11, 2022

Uh oh!

blueorangutan commented Apr 11, 2022

Uh oh!

nvazquez commented Apr 11, 2022

Uh oh!

blueorangutan commented Apr 11, 2022

Uh oh!

blueorangutan commented Apr 11, 2022

Uh oh!

nvazquez commented Oct 31, 2022

Uh oh!

nvazquez commented Mar 14, 2022 •

edited

Loading