Skip to content

UI: Fixes the style/css of deploy VM with stay on-page button. - #6108

Merged
nvazquez merged 2 commits into
apache:mainfrom
EWERK-DIGITAL:feature/fix-style-deploy-vm-stay-on-page
Mar 14, 2022
Merged

nvazquez merged 2 commits into
apache:mainfrom
EWERK-DIGITAL:feature/fix-style-deploy-vm-stay-on-page

Conversation

@utchoang

Copy link
Copy Markdown

Description

This PR fixes the style/css of deploy VM with stay on-page button.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

BEFORE:
image
AFTER:
image

How Has This Been Tested?

@utchoang

Copy link
Copy Markdown
Author

@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6108 (SL-JID-1255)

@yadvr

yadvr commented Mar 14, 2022

Copy link
Copy Markdown
Member

@utchoang @shwstppr can we rename the button to say "Launch Instance" or "Launch Instance & ..." -> the reason that we use the word "instance" while referring to VMs and would be great if we can be consistent about resource name/references throughout the UI (and docs).

@utchoang

Copy link
Copy Markdown
Author

@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6108 (SL-JID-1258)

@nvazquez nvazquez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - manually tested (CSS looks good unfortunately it does not stay on page, to be fixed soon)

@nvazquez
nvazquez merged commit 594c2c1 into apache:main Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants