Skip to content

UI: Fix navigation after delete template job is finished - #6345

Merged
nvazquez merged 1 commit into
apache:4.16from
shapeblue:fixtemplatejobsredirect
May 3, 2022
Merged

UI: Fix navigation after delete template job is finished#6345
nvazquez merged 1 commit into
apache:4.16from
shapeblue:fixtemplatejobsredirect

Conversation

@nvazquez

@nvazquez nvazquez commented May 2, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This PR fixes the redirection to the templates view after a delete template job succeeds only if the user/admin stays on the same page.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@acs-robot

acs-robot commented May 2, 2022

Copy link
Copy Markdown

Found UI changes, kicking a new UI QA build
@blueorangutan ui

@nvazquez

nvazquez commented May 3, 2022

Copy link
Copy Markdown
Contributor Author

@blueorangutan ui

@blueorangutan

blueorangutan commented May 3, 2022

Copy link
Copy Markdown

@nvazquez a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented May 3, 2022

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6345 (SL-JID-1512)

@nvazquez
nvazquez marked this pull request as ready for review May 3, 2022 11:27
@nvazquez
nvazquez requested review from Pearl1594 and utchoang May 3, 2022 11:27
GabrielBrascher
GabrielBrascher approved these changes May 3, 2022
View reviewed changes

@GabrielBrascher GabrielBrascher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yadvr yadvr added this to the 4.17.0.0 milestone May 3, 2022
@nvazquez
nvazquez force-pushed the fixtemplatejobsredirect branch from d49fdda to bb94957 Compare May 3, 2022 16:53
@nvazquez
nvazquez changed the base branch from main to 4.16 May 3, 2022 16:54
@nvazquez

nvazquez commented May 3, 2022

Copy link
Copy Markdown
Contributor Author

@blueorangutan ui

@acs-robot

acs-robot commented May 3, 2022

Copy link
Copy Markdown

Found UI changes, kicking a new UI QA build
@blueorangutan ui

@blueorangutan

blueorangutan commented May 3, 2022

Copy link
Copy Markdown

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented May 3, 2022

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6345 (SL-JID-1515)

@nvazquez
nvazquez merged commit efb1f2b into apache:4.16 May 3, 2022
yadvr pushed a commit to shapeblue/cloudstack that referenced this pull request May 18, 2022
@nvazquez @yadvr
UI: Fix templates page redirection after delete job is finished (apac…
c0c1811 
…he#6345)

(cherry picked from commit efb1f2b)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes
@GabrielBrascher GabrielBrascher GabrielBrascher approved these changes
@Pearl1594 Pearl1594 Awaiting requested review from Pearl1594
@utchoang utchoang Awaiting requested review from utchoang

Assignees

No one assigned

Labels

component:UI type:bug

Projects

None yet

Milestone

4.17.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@nvazquez @acs-robot @blueorangutan @yadvr @GabrielBrascher